<html>#2549: inlcude FLRWSolver in ET
<table style='border-spacing: 1ex 0pt; '>
<tr><td style='text-align:right'> Reporter:</td><td>Roland Haas</td></tr>
<tr><td style='text-align:right'> Status:</td><td>new</td></tr>
<tr><td style='text-align:right'>Milestone:</td><td>ET_2022_05</td></tr>
<tr><td style='text-align:right'> Version:</td><td>development version</td></tr>
<tr><td style='text-align:right'> Type:</td><td>enhancement</td></tr>
<tr><td style='text-align:right'> Priority:</td><td>major</td></tr>
<tr><td style='text-align:right'>Component:</td><td></td></tr>
</table>
<p>Comment (by Zach Etienne):</p>
<p>I’ll add comments as I have time.</p>
<p>First off, initial data thorns should depend on *Base thorns, and not any particular evolution thorn. I’m referring to </p>
<div class="codehilite"><pre><span></span><span class="n">shares</span><span class="o">:</span><span class="n">GRHydro</span>
<span class="n">USES</span> <span class="n">real</span> <span class="n">rho_abs_min</span>
<span class="n">USES</span> <span class="n">real</span> <span class="n">rho_rel_min</span>
<span class="n">USES</span> <span class="n">REAL</span> <span class="n">initial_rho_abs_min</span>
<span class="n">USES</span> <span class="n">REAL</span> <span class="n">initial_rho_rel_min</span>
<span class="n">USES</span> <span class="n">REAL</span> <span class="n">initial_atmosphere_factor</span>
<span class="n">USES</span> <span class="n">real</span> <span class="n">GRHydro_rho_central</span>
</pre></div>
<p>within <code>param.ccl</code> . It should be the initial data thorn’s responsibility to set up the atmosphere and set parameters accordingly. For me, the solver wouldn’t even get to the compile stage because I generally comment out <code>GRHydro</code> from my <code>ThornList</code> (naturally I use <code>IllinoisGRMHD</code>).</p>
<p>--<br/>
Ticket URL: <a href='https://bitbucket.org/einsteintoolkit/tickets/issues/2549/inlcude-flrwsolver-in-et'>https://bitbucket.org/einsteintoolkit/tickets/issues/2549/inlcude-flrwsolver-in-et</a></p>
</html>