<html>#2549: inlcude FLRWSolver in ET
<table style='border-spacing: 1ex 0pt; '>
<tr><td style='text-align:right'> Reporter:</td><td>Roland Haas</td></tr>
<tr><td style='text-align:right'> Status:</td><td>new</td></tr>
<tr><td style='text-align:right'>Milestone:</td><td>ET_2022_05</td></tr>
<tr><td style='text-align:right'> Version:</td><td>development version</td></tr>
<tr><td style='text-align:right'> Type:</td><td>enhancement</td></tr>
<tr><td style='text-align:right'> Priority:</td><td>major</td></tr>
<tr><td style='text-align:right'>Component:</td><td></td></tr>
</table>
<p>Comment (by Hayley Macpherson):</p>
<p><span class="ap-mention" data-atlassian-id="557058:8bc23f2a-45c0-477d-8ac4-a5a16c734278">@Zach Etienne</span> thanks for your review! I have addressed all of the issues and comments you have raised, and pushed the changes to the repo. <br>
In addition to the changes to address your issues/comments, I have also re-named the source files and routines themselves to be more consistent with ET standards. <br>
Here I’ll explain what I’ve done:</p>
<ul>
<li>Issue 1: removed these statements from param.ccl as they were unused anyway</li>
<li>Issue 2: Roland said he would have a look into this, so I’ll leave this be for now</li>
<li>Issue 3: added a test.ccl file</li>
<li>Issue 4: removed doc/cactus.sty</li>
<li>Issue 5: thanks for this! I’ve made a new routine FLRW_ParamCheck and scheduled it at ParamCheck as you suggested, and removed this code from the ID routines</li>
<li>Issue 6/Comment 2: I’ve added a comment on the example powerspectrum file in the documentation, and added a new section explaining each of the files in the tools/ directory. </li>
<li>Issue 7: I removed doc/tutorial/ and moved the README.tutorial file to tools/</li>
<li>Comment 3: I removed configs/ from the public repo and will consider contributing these to simfactory at some point</li>
<li>Issue 8: re-named the test par to FLRW_singlemode_test.par since the main differences are the resolution and simplified initial parameters</li>
<li>Issue 9: thanks for pointing this out. I’ve added a call to CCTK_WARN after checking if the supplied file exists, with a useful error explaining next steps for the user</li>
<li>Issue 10: removed the restart par file from par/</li>
<li>Issue 11/Comment 4: thanks for this - I realised random.F90 was a lot more complicated than it needed to be. It already uses the intrinsic fortran PRNG, but had some added complexity in generating a seed if it wasn’t given. In FLRWSolver, there will always be a random seed. I removed random.F90 and replaced it with a new, much simpler routine in FLRW_InitTools which directly calls t
<p>--<br/>
Ticket URL: <a href='https://bitbucket.org/einsteintoolkit/tickets/issues/2549/inlcude-flrwsolver-in-et'>https://bitbucket.org/einsteintoolkit/tickets/issues/2549/inlcude-flrwsolver-in-et</a></p>
</html>