<html>#2602: include Regge-Wheeler-Zerilli gauge self-force code in ET
<table style='border-spacing: 1ex 0pt; '>
<tr><td style='text-align:right'> Reporter:</td><td>Samuel Cupp</td></tr>
<tr><td style='text-align:right'> Status:</td><td>new</td></tr>
<tr><td style='text-align:right'>Milestone:</td><td>ET_2022_05</td></tr>
<tr><td style='text-align:right'> Version:</td><td>development version</td></tr>
<tr><td style='text-align:right'> Type:</td><td>enhancement</td></tr>
<tr><td style='text-align:right'> Priority:</td><td>major</td></tr>
<tr><td style='text-align:right'>Component:</td><td>Other</td></tr>
</table>
<p>Comment (by Peter Diener):</p>
<p>I have carefully checked the source code and have the following comments and requests for changes at this time:</p>
<p>module_scalar_rwz.f90 should be renamed to module_rwz_schw.f90</p>
<p>submodule_scalar_rwz_implementation.f90 should be renamed to<br>
submodule_rwz_schw_implementation.f90</p>
<p>In module_scalar_rwz.f90:</p>
<p>Line 16: The ford link [[submodule_scalar_schw_implementation.f90]] should be<br>
changed tp [[submodule_rwz_schw_implementation.f90]]</p>
<p>Line 29: Ford comment should not say scalar field and point charge but rather<br>
RWZ metric perturbations and point mass.</p>
<p>Line 76: [[scal_schw_save_globals_1]] should be [[rwz_schw_save_globals_1]]</p>
<p>Line 79: [[scal_schw_save_globals_2]] should be [[rwz_schw_save_globals_2]]</p>
<p>Line 82: [[scal_schw_load_globals]] should be [[rwz_schw_load_globals]]</p>
<p>Line 85: [[scal_schw_apply_filter]] should be [[rwz_schw_apply_filter]]</p>
<p>Line 87: [[scal_schw_flux]] should be [[rwz_schw_flux]]</p>
<p>Line 88: [[scal_schw:flux]] should be [[rwz_schw:flux]]</p>
<p>Lines 93-98: Why 2 functions for outputting coordinates for initial data codes?</p>
<p>Line 133: [[scal_schw]] should be [[rwz_schw]]</p>
<p>Line 141: [[scal_schw]] should be [[rwz_schw]]</p>
<p>Line 149: [[scal_schw]] should be [[rwz_schw]]</p>
<p>Line 157: [[scal_schw]] should be [[rwz_schw]]</p>
<p>Line 164: [[scal_schw_flux]] should be [[rwz_schw_flux]]</p>
<p>Line 165: [[scal_schw:flux]] should be [[rwz_schw:flux]]</p>
<p>Line 177-192: Again, as above, we two versions of the routine to write out<br>
coordinates for the initial data code.</p>
<p>In submodule_scalar_rwz_implementation.f90:</p>
<p>Line 52: The allocation of the equation name character variable should be<br>
of length 8 rather than 18.</p>
<p>Line 325: Why is the code for settinp up an initial Gaussian profile commented<br>
out when use_particle is .false.?</p>
<p>Line 352-360: As we currently only have an effective source for circular<br>
orbits, the code should abort with an error message if use_generic_orb
<p>--<br/>
Ticket URL: <a href='https://bitbucket.org/einsteintoolkit/tickets/issues/2602/include-regge-wheeler-zerilli-gauge-self'>https://bitbucket.org/einsteintoolkit/tickets/issues/2602/include-regge-wheeler-zerilli-gauge-self</a></p>
</html>