<html>#2616: Add NRPyEllipticET to the Einstein Toolkit
<table style='border-spacing: 1ex 0pt; '>
<tr><td style='text-align:right'> Reporter:</td><td></td></tr>
<tr><td style='text-align:right'> Status:</td><td>new</td></tr>
<tr><td style='text-align:right'>Milestone:</td><td></td></tr>
<tr><td style='text-align:right'> Version:</td><td></td></tr>
<tr><td style='text-align:right'> Type:</td><td>enhancement</td></tr>
<tr><td style='text-align:right'> Priority:</td><td>major</td></tr>
<tr><td style='text-align:right'>Component:</td><td></td></tr>
</table>
<p>Comment (by Leonardo Werneck):</p>
<p>Hi all. Here are the updates made to <code>NRPyEllipticET</code> based on the reviewers' comments:</p>
<ul>
<li>A brief <code>README</code> file has been added;</li>
<li><code>uuGF</code>'s description has been updated in <code>interface.ccl</code>;</li>
<li><code>info_output_freq</code>'s comment has been updated in <code>param.ccl</code>;</li>
<li><code>N2</code>'s “forbidden value” has been removed, as it was unused;</li>
<li><code>initialize_offdiagonal_metric_to_zero</code> was indeed an old parameter and has been removed;</li>
<li>All instances of <code>fprintf(stderr,...); exit();</code> have been replaced by either <code>CCTK_*ERROR</code> or <code>CCTK_*WARN</code>;</li>
<li>We have added a new parameter called <code>residual_integration_radius</code>, with a proper description of what it does;</li>
<li>Some of the algorithms are hard to describe using brief code comments. We recommend looking at the NRPy+ Jupyter notebooks for the complete description of such algorithms;</li>
<li>Thank you for pointing out that <code>CFL_FACTOR</code> was missing in <code>find_timestep.c</code>; this was actually a bug fix;</li>
<li>Unfortunately the code in <code>wavespeed_gf_all_points.c</code> depends on <code>dt</code> (the result of <code>find_timestep.c</code>) at every grid point and thus the two cannot be decoupled;</li>
<li>The reason why the <code>rfm</code> parameters have the unused attribute is similar to the reason why parameters have the attribute, i.e., not every function that uses the <code>rfm</code> includes will use <em>all</em> of the included parameters, which could lead to warnings;</li>
<li>All instances of <code>__attribute__((unused))</code> have been replaced with <code>CCTK_ATTRIBUTE_UNUSED</code>;</li>
<li>I have removed the empty files in <code>conformally_flat_BBH/rfm_files/</code> manually and am trying to figure out a way of automating this;</li>
<li><code>apply_bcs_curvilinear_radiation.c</code> and <code>set_Cparameters-SIMD.h</code> have been removed for now;</li>
<li><code>xx_to_
<p>--<br/>
Ticket URL: <a href='https://bitbucket.org/einsteintoolkit/tickets/issues/2616/add-nrpyellipticet-to-the-einstein-toolkit'>https://bitbucket.org/einsteintoolkit/tickets/issues/2616/add-nrpyellipticet-to-the-einstein-toolkit</a></p>
</html>