<html>#2692: Inclusion of FUKA importer thorns
<table style='border-spacing: 1ex 0pt; '>
<tr><td style='text-align:right'> Reporter:</td><td>tootle</td></tr>
<tr><td style='text-align:right'> Status:</td><td>new</td></tr>
<tr><td style='text-align:right'>Milestone:</td><td>ET_2023_05</td></tr>
<tr><td style='text-align:right'> Version:</td><td>ET_2023_05</td></tr>
<tr><td style='text-align:right'> Type:</td><td>proposal</td></tr>
<tr><td style='text-align:right'> Priority:</td><td>major</td></tr>
<tr><td style='text-align:right'>Component:</td><td>EinsteinToolkit thorn</td></tr>
</table>
<p>Comment (by tootle):</p>
<p><span class="ap-mention" data-atlassian-id="557058:59e031ba-9bb5-4298-a472-7b99d0ae6f22">@Roland Haas</span> <span class="ap-mention" data-atlassian-id="63ee64f4a4fdf0935c886bb1">@Konrad Topolski</span> <br>
I have put some effort into the KadathThorn which handles ensuring the kadath library exists and, if not, will be built along with all the other thorns. This still requires that the user has a compiler that is compatible with the C++17 standard and std::filesystem.</p>
<p>I have added quite some output during the build process to let the user know that HOME_KADATH will need to be set in their submit script along with the directory to use. I’m not sure if there is a good way to include this in the basic simfactory files? Maybe <span class="ap-mention" data-atlassian-id="557058:59e031ba-9bb5-4298-a472-7b99d0ae6f22">@Roland Haas</span> has a good idea for this since I never use simfactory. It is worth noting that this isn’t critical other than to utilize <code>${HOME_KADATH}/eos</code> for using the built-in EOS files for 1D tables and polytropes.</p>
<p><span class="ap-mention" data-atlassian-id="557058:59e031ba-9bb5-4298-a472-7b99d0ae6f22">@Roland Haas</span> : Additionally, I would prefer to avoid having a tarball of the library that is separately packaged and stored as an ExternalLibrary. To avoid this - during the build procedure for KadathThorn (if FUKA needs to be built) - the build script will pull the fuka submodule. I’m not sure if this goes against any best practices that ETK tries to adhere by, but it worked quite well from a testing/build standpoint.</p>
<p><span class="ap-mention" data-atlassian-id="63ee64f4a4fdf0935c886bb1">@Konrad Topolski</span> : The thorns are more or less in a final place, but I still need to write the documentation. I don’t think this will impact you though given your familiarity with the codes. The thing I would note is that in the KadathImporter there is now a test directory that includes a quick test using preexisting BH initial data. The only output is from A
<p>--<br/>
Ticket URL: <a href='https://bitbucket.org/einsteintoolkit/tickets/issues/2692/inclusion-of-fuka-importer-thorns'>https://bitbucket.org/einsteintoolkit/tickets/issues/2692/inclusion-of-fuka-importer-thorns</a></p>
</html>