<html>#2692: Inclusion of FUKA importer thorns
<table style='border-spacing: 1ex 0pt; '>
<tr><td style='text-align:right'> Reporter:</td><td>tootle</td></tr>
<tr><td style='text-align:right'> Status:</td><td>new</td></tr>
<tr><td style='text-align:right'>Milestone:</td><td>ET_2023_05</td></tr>
<tr><td style='text-align:right'> Version:</td><td>ET_2023_05</td></tr>
<tr><td style='text-align:right'> Type:</td><td>proposal</td></tr>
<tr><td style='text-align:right'> Priority:</td><td>major</td></tr>
<tr><td style='text-align:right'>Component:</td><td>EinsteinToolkit thorn</td></tr>
</table>
<p>Comment (by Roland Haas):</p>
<p>In the current KadathThorn, there is a <code>.gitmodules</code> file: </p>
<div class="codehilite"><pre><span></span><span class="k">[submodule "src/fuka"]</span>
<span class="na">path</span> <span class="o">=</span> <span class="s">src/fuka</span>
<span class="s"> url = https://bitbucket.org/fukaws/fuka/</span>
<span class="k">[submodule "fuka"]</span>
<span class="na">branch</span> <span class="o">=</span> <span class="s">fuka</span>
</pre></div>
<p>for the fuka library checked out into <code>src/fuka</code> as a git submodule. This all works and is fine.</p>
<p>However I notice that you are also including a section: </p>
<div class="codehilite"><pre><span></span><span class="k">[submodule "fuka"]</span>
<span class="na">branch</span> <span class="o">=</span> <span class="s">fuka</span>
</pre></div>
<p>which will be ignored since there is no <code>fuka</code> submodule (the submodule is <code>src/fuka</code>). Moreover, if it was <em>not</em> ignored, it would actually be an issue for the ET unless it is removed or fixed to a <code>ET_YYYY_MM</code> branch for each release branch and fixed to a specific git hash for each <code>ET_YYYY_MM_vN</code> release tag. Otherwise it points to the <em>current</em> head of that branch which is not what one would want for an ET release branch or tag (which should point to the specific, tested version that was released). </p>
<p>Since it is ignored anyway, it may be best to remove this section altogether to not give any false impression on what commit of <code>fuka</code> is actually checked out.</p>
<p>--<br/>
Ticket URL: <a href='https://bitbucket.org/einsteintoolkit/tickets/issues/2692/inclusion-of-fuka-importer-thorns'>https://bitbucket.org/einsteintoolkit/tickets/issues/2692/inclusion-of-fuka-importer-thorns</a></p>
</html>