<html>#2497: IllinoisGRMHD is incompatible with setting TmunuBase::stress_energy_at_RHS = "no"
<table style='border-spacing: 1ex 0pt; '>
<tr><td style='text-align:right'> Reporter:</td><td>Gabriele Bozzola</td></tr>
<tr><td style='text-align:right'> Status:</td><td>open</td></tr>
<tr><td style='text-align:right'>Milestone:</td><td></td></tr>
<tr><td style='text-align:right'> Version:</td><td>development version</td></tr>
<tr><td style='text-align:right'> Type:</td><td>bug</td></tr>
<tr><td style='text-align:right'> Priority:</td><td>major</td></tr>
<tr><td style='text-align:right'>Component:</td><td>EinsteinToolkit thorn</td></tr>
</table>
<p>Comment (by Leonardo Werneck):</p>
<p>After reviewing the issue more carefully, I think it is more prudent to fix it for the November release, as there won’t be enough time to fully test the code in time for this release. One possible solution is to modify IllinoisGRMHD’s <code>schedule.ccl</code> to add the con2prim function to the <code>HydroBase_Con2Prim</code> bin when <code>TmunuBase::stress_energy_at_RHS="no"</code>, e.g.,</p>
<div class="codehilite"><pre><span></span><span class="k">if</span><span class="p">(</span><span class="n">stress_energy_at_RHS</span><span class="p">)</span>
<span>{</span>
<span class="n">schedule</span> <span class="n">IllinoisGRMHD_conserv_to_prims</span> <span class="k">in</span> <span class="n">AddToTmunu</span> <span class="k">after</span> <span class="n">compute_B_and_Bstagger_from_A</span>
<span>{</span>
<span class="n">LANG</span><span class="p">:</span> <span class="k">C</span>
<span>}</span> <span class="ss">"Compute primitive variables from conservatives. This is non-trivial, requiring a Newton-Raphson root-finder."</span>
<span class="n">schedule</span> <span class="n">IllinoisGRMHD_outer_boundaries_on_P_rho_b_vx_vy_vz</span> <span class="k">in</span> <span class="n">AddToTmunu</span> <span class="k">after</span> <span class="n">IllinoisGRMHD_conserv_to_prims</span>
<span>{</span>
<span class="o">#</span> <span class="n">We</span> <span class="n">must</span> <span class="n">sync</span> <span>{</span><span class="n">P</span><span class="p">,</span><span class="n">rho_b</span><span class="p">,</span><span class="n">vx</span><span class="p">,</span><span class="n">vy</span><span class="p">,</span><span class="n">vz</span><span>}</span> <span class="n">here</span><span class="p">.</span>
<span class="n">SYNC</span><span class="p">:</span> <span class="n">grmhd_primitives_allbutBi</span>
<span class="n">LANG</span><span class="p">:</span> <span class="k">C</span>
<span>}</span> <span class="ss">"Apply outflow-only, flat BCs on {P,rho_b,vx,vy,vz}. Outflow only == velo
<p>--<br/>
Ticket URL: <a href='https://bitbucket.org/einsteintoolkit/tickets/issues/2497/illinoisgrmhd-is-incompatible-with-setting'>https://bitbucket.org/einsteintoolkit/tickets/issues/2497/illinoisgrmhd-is-incompatible-with-setting</a></p>
</html>