<html>#2735: EinsteinBase: storage declaration simplification
<table style='border-spacing: 1ex 0pt; '>
<tr><td style='text-align:right'> Reporter:</td><td>Samuel Cupp</td></tr>
<tr><td style='text-align:right'> Status:</td><td>new</td></tr>
<tr><td style='text-align:right'>Milestone:</td><td>ET_2023_11</td></tr>
<tr><td style='text-align:right'> Version:</td><td></td></tr>
<tr><td style='text-align:right'> Type:</td><td>enhancement</td></tr>
<tr><td style='text-align:right'> Priority:</td><td>trivial</td></tr>
<tr><td style='text-align:right'>Component:</td><td>EinsteinToolkit thorn</td></tr>
</table>
<p>Comment (by Samuel Cupp):</p>
<p>Right now, the PR removed them in ADMBase. They remain in HydroBase because there are many different variables using the same parameter that one may or may not need in a given run. Essentially, the ‘initial_Y_e’ and similar parameters are serving to determine whether these variables are active. However, in ADMBase the only variables with this behavior are <code>dtshift</code>, <code>dtlapse</code>, and <code>shift</code>. There’s definitely no need for shift to do this, as its storage is already controlled by <code>shift_timelevels</code>. The only question is whether we need to reintroduce the</p>
<div class="codehilite"><pre><span></span><span class="k">if</span><span class="w"> </span><span class="p">(</span><span>!</span><span class="w"> </span><span class="n">CCTK_Equals</span><span class="p">(</span><span class="n">initial_dtlapse</span><span class="p">,</span><span class="w"> </span><span class="ss">"none"</span><span class="p">))</span><span class="w"></span>
<span>{</span><span class="w"></span>
<span class="w"> </span><span class="n">dtlapse</span><span class="o">[</span><span class="n">lapse_timelevels</span><span class="o">]</span><span class="w"></span>
<span>}</span><span class="w"></span>
<span class="k">if</span><span class="w"> </span><span class="p">(</span><span>!</span><span class="w"> </span><span class="n">CCTK_Equals</span><span class="p">(</span><span class="n">initial_dtshift</span><span class="p">,</span><span class="w"> </span><span class="ss">"none"</span><span class="p">))</span><span class="w"></span>
<span>{</span><span class="w"></span>
<span class="w"> </span><span class="n">dtshift</span><span class="o">[</span><span class="n">shift_timelevels</span><span class="o">]</span><span class="w"></span>
<span>}</span><span class="w"></span>
</pre></div>
<p></p>
<p>--<br/>
Ticket URL: <a href='https://bitbucket.org/einsteintoolkit/tickets/issues/2735/einsteinbase-storage-declaration'>https://bitbucket.org/einsteintoolkit/tickets/issues/2735/einsteinbase-storage-declaration</a></p>
</html>