<html>#2742: Change Seed_Magnetic_Fields scheduling so it can be used by more thorns
<table style='border-spacing: 1ex 0pt; '>
<tr><td style='text-align:right'> Reporter:</td><td>Samuel Cupp</td></tr>
<tr><td style='text-align:right'> Status:</td><td>new</td></tr>
<tr><td style='text-align:right'>Milestone:</td><td>ET_2023_11</td></tr>
<tr><td style='text-align:right'> Version:</td><td></td></tr>
<tr><td style='text-align:right'> Type:</td><td>enhancement</td></tr>
<tr><td style='text-align:right'> Priority:</td><td>major</td></tr>
<tr><td style='text-align:right'>Component:</td><td>EinsteinToolkit thorn</td></tr>
</table>
<p>Right now, this thorn schedules based on the <code>ID_converter_ILGRMHD</code> function, preventing it from being used out-of-the-box by <code>GRHayLMHD</code>. I could change the scheduling to explicitly depend on this thorn, but a cleaner solution is to make their scheduling be based on HydroBase’s groups, providing a more consistent interface. As such, I propose that the seeding function be set to run <code>before HydroBase_Prim2ConInitial</code>. There’s a similar issue with Seed_Magnetic_Fields_BNS in that it can only be guaranteed to work with <code>Meudon_Bin_NS</code>.</p>
<p>Since both thorns should be changed to behave in a similar manner, I propose simply merging them into one. An example of this is in a <a data-is-external-link="true" href="https://bitbucket.org/zach_etienne/wvuthorns/pull-requests/14" rel="nofollow">PR</a>. However, I’m not sure of the best way to handle the deprecation/behavior changes. It might be simpler to just make a new thorn (possibly in the GRHayL repo) that provides the combined thorn while keeping the old ones in their current state.</p>
<p>This PR also contains a bug fix for <code>ID_converter_GiRaFFE</code> and a very small optional feature for <code>IllinoisGRMHD</code> which I can make separately if we decide to make a new thorn instead of changing the existing one.</p>
<p>--<br/>
Ticket URL: <a href='https://bitbucket.org/einsteintoolkit/tickets/issues/2742/change-seed_magnetic_fields-scheduling-so'>https://bitbucket.org/einsteintoolkit/tickets/issues/2742/change-seed_magnetic_fields-scheduling-so</a></p>
</html>