<html>#2747: Inclusion of sgrid importer in Einstein Toolkit
<table style='border-spacing: 1ex 0pt; '>
<tr><td style='text-align:right'> Reporter:</td><td>Samuel Cupp</td></tr>
<tr><td style='text-align:right'> Status:</td><td>new</td></tr>
<tr><td style='text-align:right'>Milestone:</td><td>ET_2023_11</td></tr>
<tr><td style='text-align:right'> Version:</td><td></td></tr>
<tr><td style='text-align:right'> Type:</td><td>enhancement</td></tr>
<tr><td style='text-align:right'> Priority:</td><td>major</td></tr>
<tr><td style='text-align:right'>Component:</td><td>EinsteinToolkit thorn</td></tr>
</table>
<p>Comment (by Samuel Cupp):</p>
<p>This means adding the thorns to the <code>einsteintoolkit.th</code> in the master branch of the manifest (<a data-is-external-link="true" href="https://bitbucket.org/einsteintoolkit/manifest/src/master/einsteintoolkit.th" rel="nofollow">link</a>). As long as the thorns are in a publicly accessible repo, it should be fine. Note that we usually make branches and tags for every single release on these repositories (see, for example, the plethora of <code>ET_YYYY_MM</code> branches in <a data-is-external-link="true" href="https://bitbucket.org/zach_etienne/wvuthorns/src/master/" rel="nofollow">wvuthorns</a>). This either means giving the ET maintainers permission to create branches in the repository (and possibly letting any future release managers/maintainers have access) or be willing to create these branches and tags on behalf of the ET. Generally, letting at least a few of the senior maintainers have commit access will help ensure smooth future releases in case people get sick or something at the same time as a release.</p>
<p>So right now, the most important thing is making sure we put in the correct information. Based on what is in the linked git repo, it is</p>
<div class="codehilite"><pre><span></span><span class="sx">!TARGET = $ARR</span>
<span class="sx">!TYPE = git</span>
<span class="sx">!URL = https://github.com/wofti/CactusSgrid.git</span>
<span class="sx">!REPO_PATH = ..</span>
<span class="sx">!CHECKOUT =</span>
<span class="n">CactusSgrid</span><span class="o">/</span><span class="n">DNSdata</span>
</pre></div>
<p>If that’s all we need to add, then I can do that today. </p>
<p><span class="ap-mention" data-atlassian-id="634afd8853df3c01232121fd">@Roland Haas</span> what does the <code>$2</code> that most thorns use mean for repo_path? I ask because I don’t know if the <code>..</code> in the above is what GetComponents normally expects or not.</p>
<p>--<br/>
Ticket URL: <a href='https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein'>https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgrid-importer-in-einstein</a></p>
</html>