<html>#2802: compilation faiulres in TwoPunctures_BBHSF and TwoPunctures_KerrProca with gcc14
<table style='border-spacing: 1ex 0pt; '>
<tr><td style='text-align:right'> Reporter:</td><td>Roland Haas</td></tr>
<tr><td style='text-align:right'> Status:</td><td>new</td></tr>
<tr><td style='text-align:right'>Milestone:</td><td></td></tr>
<tr><td style='text-align:right'> Version:</td><td></td></tr>
<tr><td style='text-align:right'> Type:</td><td>bug</td></tr>
<tr><td style='text-align:right'> Priority:</td><td>major</td></tr>
<tr><td style='text-align:right'>Component:</td><td>EinsteinToolkit thorn</td></tr>
</table>
<p>GCC14 remove implicit pointer casts and requires explicit casts for C in the same manner that C++ requires them.</p>
<p><a data-is-external-link="true" href="https://gcc.gnu.org/gcc-14/porting_to.html" rel="nofollow">https://gcc.gnu.org/gcc-14/porting_to.html</a></p>
<p>This affects TwoPunctures and thus all thorns that are derived from TwoPunctures. Typical compile failures are error messages such as:</p>
<div class="codehilite"><pre><span></span><code><span>COMPILING Proca/TwoPunctures_KerrProca/src/Newton.c</span>
<span>/Users/rhaas/Cactus/configs/sim/build/TwoPunctures_KerrProca/Newton.c: In function 'TPKP_TestRelax':</span>
<span>/Users/rhaas/Cactus/configs/sim/build/TwoPunctures_KerrProca/Newton.c:287:37: error: passing argument 6 of 'resid' from incompatible pointer type [-Wincompatible-pointer-types]</span>
<span> 287 | resid (res, ntotal, dv, F, ncols, cols, JFD);</span>
<span> | ^~~~</span>
<span> | |</span>
<span> | int **</span>
</code></pre></div>
<p>This is fixed for TwoPunctures in <a data-is-external-link="true" href="https://bitbucket.org/einsteintoolkit/einsteininitialdata/pull-requests/18" rel="nofollow">https://bitbucket.org/einsteintoolkit/einsteininitialdata/pull-requests/18</a> but the patch used there does not cleanly apply to the derived codes (possibly due to some extra lines of code being present).</p>
<p>--<br/>
Ticket URL: <a href='https://bitbucket.org/einsteintoolkit/tickets/issues/2802/compilation-faiulres-in-twopunctures_bbhsf'>https://bitbucket.org/einsteintoolkit/tickets/issues/2802/compilation-faiulres-in-twopunctures_bbhsf</a></p>
</html>