<html>#2823: Include TOVola: An enhanced TOV solver with Tabulated EOS support
<table style='border-spacing: 1ex 0pt; '>
<tr><td style='text-align:right'> Reporter:</td><td>David Boyer</td></tr>
<tr><td style='text-align:right'> Status:</td><td>open</td></tr>
<tr><td style='text-align:right'>Milestone:</td><td>ET_2024_11</td></tr>
<tr><td style='text-align:right'> Version:</td><td></td></tr>
<tr><td style='text-align:right'> Type:</td><td>enhancement</td></tr>
<tr><td style='text-align:right'> Priority:</td><td>major</td></tr>
<tr><td style='text-align:right'>Component:</td><td>EinsteinToolkit thorn</td></tr>
</table>
<p>Comment (by Roland Haas):</p>
<p>Comments looking at TOVola:<br>
</p>
<ol>
<li>the documentation does not adhere to the rules in <a data-is-external-link="true" href="http://einsteintoolkit.org/usersguide/UsersGuide.html#x1-115000C1.8.4" rel="nofollow">http://einsteintoolkit.org/usersguide/UsersGuide.html#x1-115000C1.8.4</a> namely it does not correctly “namespace” the bibtex keys (important when building the ThornGuide which would see conflicting keys)</li>
<li><code>STRING TOVola_ODE_method</code> in <code>param.ccl</code> should be <code>KEYWORD TOVola_ODE_method</code></li>
<li><code>0.0:* :: "Must be Positive"</code> is incorrect, unless non-negative is enough. Should use <code>(0.0:* :: "Must be positive"</code> as the range (assuming the docs <a data-is-external-link="true" href="http://einsteintoolkit.org/usersguide/UsersGuide.html#x1-187000D2.3.2" rel="nofollow">http://einsteintoolkit.org/usersguide/UsersGuide.html#x1-187000D2.3.2</a> still reflect the code and open intervals for double valued parameters have not been silently removed)</li>
<li>same as 3 for <code>TOVola_absolute_max_step</code> and <code>TOVola_absolute_min_step</code> and possibly others</li>
<li><code>STEERABLE=always</code> probably makes no sense for a parameter used by an ID thorn, could be removed</li>
<li>test parameter files produce <code>*.par</code> files in output, violating <a data-is-external-link="true" href="https://docs.einsteintoolkit.org/et-docs/Adding_a_test_case" rel="nofollow">https://docs.einsteintoolkit.org/et-docs/Adding_a_test_case</a></li>
<li><code>#include <cctk.h></code> should be before any other includes (incl. system ones, since it brings in any DEFINES produced by ExternalLibraries). Should used <code>#include "cctk.h"</code> since <code>cctk.h</code>is not a a system provided include file (<a data-is-external-link="true" href="https://www.gnu.org/software/c-intro-and-ref/manual/html_node/include-Syntax.html" rel="nofollow">https://www.gnu.org/software/c-intro-and-ref/manual/html_node/include-Syntax.html</a> and <a data-is-ex
<p>--<br/>
Ticket URL: <a href='https://bitbucket.org/einsteintoolkit/tickets/issues/2823/include-tovola-an-enhanced-tov-solver-with'>https://bitbucket.org/einsteintoolkit/tickets/issues/2823/include-tovola-an-enhanced-tov-solver-with</a></p>
</html>