<html>#2871: EOS_Omni's nuceos code used int to hold hid_t values
<table style='border-spacing: 1ex 0pt; '>
<tr><td style='text-align:right'> Reporter:</td><td>Roland Haas</td></tr>
<tr><td style='text-align:right'> Status:</td><td>open</td></tr>
<tr><td style='text-align:right'>Milestone:</td><td></td></tr>
<tr><td style='text-align:right'> Version:</td><td></td></tr>
<tr><td style='text-align:right'> Type:</td><td>bug</td></tr>
<tr><td style='text-align:right'> Priority:</td><td>major</td></tr>
<tr><td style='text-align:right'>Component:</td><td>EinsteinToolkit thorn</td></tr>
</table>
<p>Comment (by Erik Schnetter):</p>
<p>I recommend two further changes for safety:</p>
<ul>
<li>Add parentheses around <code>fn_call</code></li>
<li>Add a <code>do { } while (0)</code> construct around the current <code>if</code> construct. I’m not sure whether the current <code>if</code> construct is working as expected if it is followed directly by an <code>else</code> keyword.</li>
</ul>
<p>Approved.</p>
<p></p>
<p>--<br/>
Ticket URL: <a href='https://bitbucket.org/einsteintoolkit/tickets/issues/2871/eos_omnis-nuceos-code-used-int-to-hold'>https://bitbucket.org/einsteintoolkit/tickets/issues/2871/eos_omnis-nuceos-code-used-int-to-hold</a></p>
</html>