<html>#6: Inconsistent computation of the volume form in Coordinates (llama) between Thornburg04/13 and default behavior
<table style='border-spacing: 1ex 0pt; '>
<tr><td style='text-align:right'> Reporter:</td><td>Jordan Nicoules</td></tr>
<tr><td style='text-align:right'> Status:</td><td>submitted</td></tr>
<tr><td style='text-align:right'>Milestone:</td><td></td></tr>
<tr><td style='text-align:right'> Version:</td><td></td></tr>
<tr><td style='text-align:right'> Type:</td><td>bug</td></tr>
<tr><td style='text-align:right'> Priority:</td><td>major</td></tr>
<tr><td style='text-align:right'>Component:</td><td></td></tr>
</table>
<p>See ticket:
<a href="https://bitbucket.org/einsteintoolkit/tickets/issues/2912/inconsistent-computation-of-the-volume" rel="nofollow" class="ap-connect-link">https://bitbucket.org/einsteintoolkit/tickets/issues/2912/inconsistent-computation-of-the-volume</a></p>
<p><strong>IMPORTANT WARNING: THIS IS A BEHAVIOR CHANGE AND MAY BREAK BACKWARD COMPATIBILITY FOR NON-THORNBURG04/13 RUNS!</strong></p>
<h1 id="markdown-header-modifications-to-implement">Modifications to implement:</h1>
<h2 id="markdown-header-coordinatessrcinverse_jacobianf90">Coordinates/src/inverse_jacobian.F90</h2>
<p>See attached file.</p>
<h3 id="markdown-header-warning">WARNING</h3>
<p>This was tested only on Thornburg04 and Thornburg04nc.
Thornburg13 works like Thornburg04 and redefines its volume form, so it should be fine.
For other patch systems, I'm not sure if this is safe for each subpatch, but I think that shouldn't be more wrong than the current implementation.</p>
<h3 id="markdown-header-note">NOTE</h3>
<p>Feel free to change the comments I made, and/or adapt the existing TODO in comment (lines 59-61) if it's relevant.</p>
<h2 id="markdown-header-coordinatessrcthornburg04cc">Coordinates/src/thornburg04.cc</h2>
<p>Fix typo in comment line 1439:
<code>// set volume form to determinant of Jacobian</code></p>
<h2 id="markdown-header-coordinatessrcthornburg13cc">Coordinates/src/thornburg13.cc</h2>
<p>Fix typo in comment line 2237:
<code>// set volume form to determinant of Jacobian</code></p>
<p><table><tr><td>attachment:</td><td><a href="https://api.bitbucket.org/2.0/repositories/llamacode/llama/issues/6/attachments/inverse_jacobian.F90">inverse_jacobian.F90</a></td></tr>
</table></p>
<p>--<br/>
Ticket URL: <a href='https://bitbucket.org/llamacode/llama/issues/6/inconsistent-computation-of-the-volume'>https://bitbucket.org/llamacode/llama/issues/6/inconsistent-computation-of-the-volume</a></p>
</html>