[Users] [Commits] [svn:einsteintoolkit] GRHydro/trunk/ (Rev. 301)

[Roland Haas]

Hello Erik,

> I may be overlooking something, but doesn't Fortran already keep track
> of whether arrays are allocated? There is no need to introduce a
> logical variable, one can call "allocated" instead.
That is certainly true. The status variable is extra complication and
one could simply use Fortran's ALLOCATED() function to check status.

> Another point is that explicit memory management at shutdown isn't
> really useful. It adds more code, adds complexity to keep track of
> things, and delays the shutdown because extra things happen.
I agree that it adds extra complication and is not terribly useful. We
can certainly remove it. I doubt calling the equivalent of free() slows
down shutdown noticably though  :-) I did the minimal change without
modifying the initial intent of the author (since the status variable
was already present).

> I would simply call "allocate" in ENOSetup, schedule the routine such
> that it is called only once, and leave it at this, removing about 20
> or 30 lines of code and the possibility of error.
Fine with me. If there are not protests I will do so near the end of the
week.

Yours,
Roland

-- 
My email is as private as my paper mail. I therefore support encrypting
and signing email messages. Get my PGP key from http://keys.gnupg.net.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: OpenPGP digital signature
Url : http://lists.einsteintoolkit.org/pipermail/users/attachments/20111121/cd616ad4/attachment.bin