[Users] [Einstein Toolkit] #590: McLachlan should allow other thorns to set the gauge

Einstein Toolkit trac-noreply at einsteintoolkit.org
Thu Apr 25 09:37:32 CDT 2013


#590: McLachlan should allow other thorns to set the gauge
------------------------------------+---------------------------------------
  Reporter:  bmundim                |       Owner:  diener    
      Type:  defect                 |      Status:  assigned  
  Priority:  major                  |   Milestone:  ET_2013_05
 Component:  EinsteinToolkit thorn  |     Version:            
Resolution:                         |    Keywords:            
------------------------------------+---------------------------------------

Comment (by eschnett):

 This is a fairly invasive change to a very fundamental thorn. Such a
 change needs thorough testing.

 Peter says above that he didn't run the full set of test cases yet.

 This patch is also missing new test cases, both for the general case
 (everything handled by McLachlan) as well as the new cases (either lapse
 and/or shift handled by another mechanism). Presumably, one would not just
 record the new results, but also test that the results are correct, e.g.
 ensuring convergence with a gauge wave test case.

 What other thorn would make use of this functionality? I assume that those
 who asked for this functionality would be happy to test it with their
 additional gauge thorns (even if those are private thorns). If there is no
 one volunteering for such testing, then it would seem that we are
 developing functionality that is not actually currently needed.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/590#comment:19>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit


More information about the Users mailing list