[Users] IllinoisGRMHD Code Compatibility Layer

[Erik Schnetter]

Zach

Apologies for missing half of the discussion this morning -- I had an
unexpected visitor in my office.

- Is it necessary to have an explicit conversion thorn? Couldn't these
routines be simply part of IllinoisGRMHD? For example, McLachlan uses its
own variable, and contains its own routines to convert from/to ADMBase.

- If the routines really need to exist in two thorns, then I suggest having
the actual routines in only one place, and calling the routines from the
other place. (I probably completely missed the original motivation.) If
necessary, you would need to introduce a third thorn containing these
routines that these two thorns can call.

- Symbolic links will in general not work since they will lead to two
different routines with the same name, something that confuses the Unix
linker and may lead to random problems (segfaults, undefined symbols at
link time, etc.) If identical code exists in different thorns, then the
routines must have different names.

- Would scheduling "IN initial AFTER HydroBase_Initial" work?

- Similarly, there should be a group HydroBase_SetHydroBaseVars where the
respective routine should be scheduled. I think half of the functionality
that is present in ADMBase is still missing from HydroBase since, so far,
there was only one thorn (... or two very similar thorns ...) that used
HydroBase. Feel free to suggest the respective extensions to HydroBase,
modelled after ADMBase if possible.

-erik



On Mon, Aug 17, 2015 at 11:49 AM, Zach Etienne <zachetie at gmail.com> wrote:

> Hi all,
>
> In conjunction with the recent update to IllinoisGRMHD, I just made public
> a couple of thorns that provide a HydroBase <-> IllinoisGRMHD compatibility
> layer.
>
> ID_converter_ILGRMHD: This thorn converts Valencia formulation variables
> into variables IllinoisGRMHD can read, making it possible to input
> HydroBase-compatible initial data into IllinoisGRMHD.
>
> convert_to_HydroBase: This thorn converts IllinoisGRMHD GRMHD variables
> into variables compatible with HydroBase every "convert_to_HydroBase_every"
> iterations. This thorn enables you to use HydroBase-compatible analysis
> thorns with IllinoisGRMHD.
>
> There are a couple items on the TODO list for these thorns:
> 1) Because there is no uniform scheduling bin that runs after
> HydroBase_Initial, one must edit ID_converter_ILGRMHD/schedule.ccl to force
> the ID converter to be run AFTER the final initial data function in
> HydroBase_Initial
>
> 2) As we discussed during the Aug 17, 2015 ET telecon, there are symlinks
> inside these thorns to IllinoisGRMHD source code, requiring these thorns to
> be placed in the same subdirectory as the main IllinoisGRMHD code. If the
> symlinks must go, I would like to know the least painful way of getting rid
> of these symlinks without duplicating code.
>
> Here's a link to the bitbucket repo:
> https://bitbucket.org/zach_etienne/illinoisgrmhd_compatibilitylayer
>
> -Zach
>
> *     *     *
> Zachariah Etienne
> Assistant Professor of Mathematics
> West Virginia University
>
> _______________________________________________
> Users mailing list
> Users at einsteintoolkit.org
> http://lists.einsteintoolkit.org/mailman/listinfo/users
>
>


-- 
Erik Schnetter <schnetter at cct.lsu.edu>
http://www.perimeterinstitute.ca/personal/eschnetter/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.einsteintoolkit.org/pipermail/users/attachments/20150817/d7a48a97/attachment-0001.html