[Users] Hydro_RNSID Inherits from GRHydro
rhaas at illinois.edu
Mon Nov 5 12:33:38 CST 2018
> Hydro_RNSID inherits from GRHydro, which goes against the usual policy that
> initial data thorns depend only on HydroBase / ADMBase. Is there a plan to
> fix this? Is a fix even difficult?
There's a pull request (8 months old) that fixes this here:
Since I am the author I cannot review it, but anyone else can.
Note that this *could* induce a slight change in variables since
GRHydro's prim2con may not quite compute the conserved variables in the
very same way that Hydro_RNSID computed the primitives.
We *could* get perfect backwards compatibility by adding a parameter
and having Hydro_RNSID do what it does now if the parameter is set to
"yes" (which would be the default). One has to get the variable
pointers from VarDataPtr and probably should check for GRHydro being
active in ParamCheck.
My email is as private as my paper mail. I therefore support encrypting
and signing email messages. Get my PGP key from http://pgp.mit.edu .
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 833 bytes
Desc: OpenPGP digital signature
Url : http://lists.einsteintoolkit.org/pipermail/users/attachments/20181105/1d905834/attachment.bin
More information about the Users