The reason for this change was the past timelevels were left uninitialised after postregridinitial. The previous sequence was:<div>1. fill timelevels</div><div>2. regrid</div><div>3. postregridinitial on current timelevel</div>
<div><br></div><div>This leaves the past timelevels potentially uninitialised. And when init_fill_timlevels is set, then no other method will set up these past timelevels. Things work fine if this regridding step is a no-op, which will be the case for most current setups, as in this case the past timelevels remain defined.</div>
<div><br></div><div>My change re-applied the "fill timelevels" after postregridinitial. This should be a no-op, except if postregridinitial modified the current timelevel. In this case, copying these data to the past timelevels is arguably the correct thing to do.</div>
<div><br></div><div>-erik</div><div><br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Nov 27, 2012 at 3:03 AM, Ian Hinder <span dir="ltr"><<a href="mailto:ian.hinder@aei.mpg.de" target="_blank">ian.hinder@aei.mpg.de</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im"><br>
On 27 Nov 2012, at 08:39, <a href="mailto:rhaas@tapir.caltech.edu">rhaas@tapir.caltech.edu</a> wrote:<br>
<br>
> User: rhaas<br>
> Date: 2012/11/27 01:39 AM<br>
><br>
> Modified:<br>
> /trunk/test/teukolsky/<br>
> Psi4i.d.asc, Psi4i.x.asc, Psi4i.y.asc, Psi4i.z.asc, Psi4r.d.asc, Psi4r.x.asc, Psi4r.y.asc, Psi4r.z.asc<br>
><br>
> Log:<br>
> WeylScal4: regenerate test data after Carpet change<br>
><br>
> Carpet's 6b5c318bb1057851d0ee1b5bba6e633c5cf31ca6 which re-copies<br>
> init_fill_timelevels after initial restriction affects the ID we see and hence<br>
> the final answer<br>
<br>
</div>Hi all,<br>
<br>
This sounds like it might change results for more than just this one test case. Does more test data need to be regenerated, and does this affect reproducibility of simulations? Erik, what was the reason for this change in Carpet? Am I worrying for nothing?<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
Ian Hinder<br>
<a href="http://numrel.aei.mpg.de/people/hinder" target="_blank">http://numrel.aei.mpg.de/people/hinder</a><br>
<br>
_______________________________________________<br>
Users mailing list<br>
<a href="mailto:Users@einsteintoolkit.org">Users@einsteintoolkit.org</a><br>
<a href="http://lists.einsteintoolkit.org/mailman/listinfo/users" target="_blank">http://lists.einsteintoolkit.org/mailman/listinfo/users</a><br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br>Erik Schnetter <<a href="mailto:schnetter@cct.lsu.edu" target="_blank">schnetter@cct.lsu.edu</a>><br><a href="http://www.perimeterinstitute.ca/personal/eschnetter/" target="_blank">http://www.perimeterinstitute.ca/personal/eschnetter/</a><br>
</div>