Adding thorn Fortran does not imply checking Fortran prototypes. For this, one has to explicitly add "use cctk" in all modules and routines as well.<div><br></div><div>-erik</div><div class="gmail_extra"><br><br>
<div class="gmail_quote">On Tue, Nov 27, 2012 at 5:27 PM, Einstein Toolkit <span dir="ltr"><<a href="mailto:trac-noreply@einsteintoolkit.org" target="_blank">trac-noreply@einsteintoolkit.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">#1152: Add option to compute center of mass to hydro_analysis and lots of smaller<br>
changes<br>
</div>------------------------------------+---------------------------------------<br>
Reporter: rhaas | Owner:<br>
Type: enhancement | Status: review<br>
<div class="im"> Priority: minor | Milestone:<br>
Component: EinsteinToolkit thorn | Version:<br>
</div>Resolution: | Keywords: Hydro_Analysis<br>
------------------------------------+---------------------------------------<br>
<br>
Comment (by rhaas):<br>
<br>
Replying to [comment:5 knarf]:<br>
<div class="im"> > 0003-Hydro_Analysis-use-Fortran-modules-for-prototypes-if.patch: I<br>
assume this is preparing following patches, e.g., 0004. Now, these then<br>
use the table-interfaces from Fortan. Wouldn't that make this not only<br>
optional but required? Do later patches compile without the FORTAN<br>
capability?<br>
<br>
</div> Fortran does not require prototypes and all functions are all usable<br>
without the module. So this patch is purely optional. I like having<br>
prototypes if possible since they help me catch errors.<br>
<br>
All patches seem to compile fine without Fortran modules present. I just<br>
verified this by removing Fortran from my thornlist, which also disables<br>
QuasiLocalMeasures.<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
Ticket URL: <<a href="https://trac.einsteintoolkit.org/ticket/1152#comment:7" target="_blank">https://trac.einsteintoolkit.org/ticket/1152#comment:7</a>><br>
</font></span><div class="HOEnZb"><div class="h5">Einstein Toolkit <<a href="http://einsteintoolkit.org" target="_blank">http://einsteintoolkit.org</a>><br>
The Einstein Toolkit<br>
_______________________________________________<br>
Trac mailing list<br>
<a href="mailto:Trac@einsteintoolkit.org">Trac@einsteintoolkit.org</a><br>
<a href="http://lists.einsteintoolkit.org/mailman/listinfo/trac" target="_blank">http://lists.einsteintoolkit.org/mailman/listinfo/trac</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>Erik Schnetter <<a href="mailto:schnetter@cct.lsu.edu" target="_blank">schnetter@cct.lsu.edu</a>><br><a href="http://www.perimeterinstitute.ca/personal/eschnetter/" target="_blank">http://www.perimeterinstitute.ca/personal/eschnetter/</a><br>
</div>