<div dir="ltr">Hi Ian,<div><br></div><div><span style="font-size:12.8000001907349px">> Just a quick comment: maybe it would be possible to isolate all such "extra" functionality in a single source file, and make it clear that this is only present for compatibility, and isn't relevant to the internal workings of the thorn. It is true that</span></div><div><span style="font-size:12.8000001907349px">> compatibility code can make things cluttered, but maybe having it separate would be enough?</span><br></div><div><span style="font-size:12.8000001907349px"><br></span></div><div><span style="font-size:12.8000001907349px">Thanks for your comment.</span></div><div><span style="font-size:12.8000001907349px"><br></span></div><div><span style="font-size:12.8000001907349px">U</span><span style="font-size:12.8000001907349px">sing Carpet/CarpetLib thorns as a template, </span><span style="font-size:12.8000001907349px">I was able to figure out how to remove the symlinks. In my previous email, I define [Function A] and [Function B]. Regarding splitting this functionality into a single source file, </span></div><div><span style="font-size:12.8000001907349px"><br></span></div><div><span style="font-size:12.8000001907349px">* [Function A] exists within a source file called, appropriately enough, "convert_ADM_to_BSSN__enforce_detgtij_eq_1__and_compute_gtupij.C"</span></div><div><span style="font-size:12.8000001907349px">* [Function B] exists next to a function that applies a fix ("apply_tau_floor") to the conservative variables, and both exist within a source file called: "apply_tau_floor__enforce_limits_on_primitives_and_recompute_conservs.C"</span></div><div><span style="font-size:12.8000001907349px"><br></span></div><div><span style="font-size:12.8000001907349px">Now that the symlinks issue has been resolved, I would be happy to hear any suggestions or comments you have regarding the current IllinoisGRMHD & related thorns.</span></div></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature"><div dir="ltr"><div>-Zach</div><div><br></div>* * *<br>Zachariah Etienne<br>Assistant Professor of Mathematics<div>West Virginia University<br></div></div></div></div>
<br><div class="gmail_quote">On Tue, Aug 18, 2015 at 5:48 AM, Ian Hinder <span dir="ltr"><<a href="mailto:ian.hinder@aei.mpg.de" target="_blank">ian.hinder@aei.mpg.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><br><div><span class=""><div>On 17 Aug 2015, at 20:23, Zach Etienne <<a href="mailto:zachetie@gmail.com" target="_blank">zachetie@gmail.com</a>> wrote:</div><br><blockquote type="cite"><div dir="ltr">Hi Erik,<div><br></div><div>Great questions.</div><div><br></div><div><div style="font-size:12.8000001907349px">- Is it necessary to have an explicit conversion thorn? Couldn't these routines be simply part of <span style="font-size:13px">IllinoisGRMHD? For example, McLachlan uses its own variable, and contains its own routines to convert from/to ADMBase.</span></div></div><div><span style="font-size:13px"><br></span></div><div>IllinoisGRMHD is designed to maximize user-friendliness, and to this end one of my goals is to minimize the amount of source code inside IllinoisGRMHD that is not directly related to GRMHD evolution. Thus if possible, I would prefer not incorporating functionality from these thorns into IllinoisGRMHD.</div></div></blockquote><div><br></div></span><div>Just a quick comment: maybe it would be possible to isolate all such "extra" functionality in a single source file, and make it clear that this is only present for compatibility, and isn't relevant to the internal workings of the thorn. It is true that compatibility code can make things cluttered, but maybe having it separate would be enough?</div></div><span class="HOEnZb"><font color="#888888"><br><div>
<div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div>-- </div><div>Ian Hinder</div><div><a href="http://members.aei.mpg.de/ianhin" target="_blank">http://members.aei.mpg.de/ianhin</a></div></div></div></div></div>
</div>
<br></font></span></div></blockquote></div><br></div>