<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Hi,<div><br></div><div>I have just read the notes at </div><div><br></div><div><span class="Apple-tab-span" style="white-space:pre"> </span><a href="https://docs.einsteintoolkit.org/et-docs/adding_a_test_case">https://docs.einsteintoolkit.org/et-docs/adding_a_test_case</a></div><div><br></div><div>and wanted to make a comment. It says there that the test cases should run in < 2 minutes. We currently have 400 tests, so if all tests took 2 minutes, the tests would take 13 hours to run. They currently run in 30 minutes, and many tests take less than a second. I would modify the guidelines to say</div><div><br></div><div><span class="Apple-tab-span" style="white-space:pre"> </span>"Tests should run as quickly as possible; ideally in less than one second. Longer tests are OK if this is absolutely necessary to test for regressions."</div><div><br></div><div>You can see an overview of the test run times at</div><div><br></div><div><span class="Apple-tab-span" style="white-space:pre"> </span><a href="https://build.barrywardell.net/job/EinsteinToolkit/lastCompletedBuild/testReport/(root)/">https://build.barrywardell.net/job/EinsteinToolkit/lastCompletedBuild/testReport/(root)/</a></div><div><br></div><div>You can click on "Duration" to sort by duration. Note that this is listed by thorn; you can click on an individual thorn to break the times down into individual tests. I don't know how to find the longest running tests across all thorns.</div><div><br></div><div>PS: I don't know who wrote that wiki page as they didn't log in to the wiki, so only an IP address is recorded. Please use your wiki accounts if you have one!</div><div><br><div apple-content-edited="true">
<div style="color: rgb(0, 0, 0); letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div style="color: rgb(0, 0, 0); letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div style="color: rgb(0, 0, 0); letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div style="color: rgb(0, 0, 0); letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>-- </div><div>Ian Hinder</div><div><a href="http://members.aei.mpg.de/ianhin">http://members.aei.mpg.de/ianhin</a></div></div></div></div></div>
</div>
<br></div></body></html>