<div dir="auto">Hi Roland,<div dir="auto"><br></div><div dir="auto">I'm worried about staggered gridfunction support, any tweaks that might influence scheduling, reduction operations, and support for non-Lagrange prolongation/restrictions... just to name a few bits of carpet functionality that might not be tested by the qc0 par file. </div></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Oct 3, 2018, 10:25 Roland Haas <<a href="mailto:rhaas@illinois.edu">rhaas@illinois.edu</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello Zach,<br>
<br>
> I'm always nervous when a big Carpet update comes down the pipeline. <br>
I would not call it a big update since these are changes from 2016<br>
onwards and had they trickled in at the rate they were produced, no one<br>
would have noticed. Just lots of changes lines (due to changes of<br>
CCTK_VWarn to CCTK_WARN and reformatting of code).<br>
<br>
> Could<br>
> you please confirm the full ETK testsuite passes with the new version of<br>
> Carpet before pushing to master? There are a lot of Carpet features that<br>
> aren't tested by qc0-mclachlan.par, but are tested by the testsuite.<br>
Sure I will run the testsuites (must do so anyway before applying the<br>
changes), thank you for reminding me of the requirement.<br>
<br>
Which features do you have in mind and are particularly worried about?<br>
Llama support for example is not tested in either one qc0-mclachlan or<br>
the test suites as far as I know. Note that the results for<br>
qc0-mclachlan.par are not just "similar" they are identical (in the<br>
mp_psi4_l2_m2.asc output file ie this tests quite a bit of the<br>
infrastructure).<br>
<br>
Yours,<br>
Roland<br>
<br>
-- <br>
My email is as private as my paper mail. I therefore support encrypting<br>
and signing email messages. Get my PGP key from <a href="http://pgp.mit.edu" rel="noreferrer noreferrer" target="_blank">http://pgp.mit.edu</a> .<br>
</blockquote></div>