<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p><br>
</p>
<div class="moz-cite-prefix">On 11/5/18 12:33 PM, Roland Haas wrote:<br>
</div>
<blockquote type="cite" cite="mid:20181105123338.11ce1dad@ekohaes8">
<pre class="moz-quote-pre" wrap="">Hello all,
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Hydro_RNSID inherits from GRHydro, which goes against the usual policy that
initial data thorns depend only on HydroBase / ADMBase. Is there a plan to
fix this? Is a fix even difficult?
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">There's a pull request (8 months old) that fixes this here:
<a class="moz-txt-link-freetext" href="https://trac.einsteintoolkit.org/ticket/2128">https://trac.einsteintoolkit.org/ticket/2128</a>
Since I am the author I cannot review it, but anyone else can.</pre>
</blockquote>
<p>You can, however, nag people and ask repeatedly about reviews on
the mailing list.</p>
<p>--Steve<br>
</p>
<blockquote type="cite" cite="mid:20181105123338.11ce1dad@ekohaes8">
<pre class="moz-quote-pre" wrap="">
Note that this *could* induce a slight change in variables since
GRHydro's prim2con may not quite compute the conserved variables in the
very same way that Hydro_RNSID computed the primitives.
We *could* get perfect backwards compatibility by adding a parameter
and having Hydro_RNSID do what it does now if the parameter is set to
"yes" (which would be the default). One has to get the variable
pointers from VarDataPtr and probably should check for GRHydro being
active in ParamCheck.
Yours,
Roland
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
Users mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Users@einsteintoolkit.org">Users@einsteintoolkit.org</a>
<a class="moz-txt-link-freetext" href="http://lists.einsteintoolkit.org/mailman/listinfo/users">http://lists.einsteintoolkit.org/mailman/listinfo/users</a>
</pre>
</blockquote>
</body>
</html>