<div dir="ltr">Roland,<div> thanks for the info. We will follow these steps. Federico did also a pull request recently of the new Hydro_Analysis thorn.</div><div><br></div><div>Cheers,</div><div>Bruno</div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr">Il giorno gio 8 nov 2018 alle ore 16:33 Roland Haas <<a href="mailto:rhaas@illinois.edu">rhaas@illinois.edu</a>> ha scritto:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello Bruno,<br>
<br>
with trac allowing external accounts, you, Federica nad Nargess should<br>
be able to create a ticket with the enhancement for inclusion in the<br>
ET. Ideally your proposed patch would include a testsuite case (eg a<br>
resolution reduced version of the parfile you used to verify this<br>
against TOVSolver's results).<br>
<br>
The official rules for contributions are listed here: <br>
<br>
<a href="https://www.einsteintoolkit.org/contribute.html" rel="noreferrer" target="_blank">https://www.einsteintoolkit.org/contribute.html</a><br>
<br>
in particular<br>
<br>
<br>
* Components should be of sufficient quality to be used for peer-reviewed and<br>
published science. This includes a basic standard of software engineering,<br>
documentation of the software including algorithms and methods, tutorials and<br>
examples, and self-tests to demonstrate that the software works correctly.<br>
* To focus development and support, optimize resources, and provide best<br>
practises, the Einstein Toolkit components should be of current interest to<br>
the community.<br>
* All components must be distributed under an open source licence so that<br>
others can use these components without restrictions (except as mandated by<br>
scientific integrity), can modify and improve them as necessary, and can pass<br>
on these modifications to their collaborators as they see fit.<br>
<br>
though those are really geared towards bigger contributions like whole<br>
thorns and not small additions to functionality.<br>
<br>
Yours,<br>
Roland<br>
<br>
> Hi,<br>
> two collaborators of mine (Federico Cipolletta and Narges Shahamat, both<br>
> in cc to this email) have modified Hydro_Analysis in order to compute also<br>
> the rest mass. They are still cleaning the code, but maybe they can say a<br>
> few words about what they did and discuss how to commit these changes to<br>
> the Einstein Toolkit.<br>
> <br>
> Cheers,<br>
> Bruno<br>
> <br>
> <br>
> Il giorno dom 4 nov 2018 alle ore 19:46 Roland Haas <<a href="mailto:rhaas@illinois.edu" target="_blank">rhaas@illinois.edu</a>> ha<br>
> scritto:<br>
> <br>
> > Hello all,<br>
> ><br>
> > for those in Europe, please keep in mind that the US has not yet<br>
> > changed over to standard time, ie 9:00am US central is 15:00 CET ie one<br>
> > hour earlier than usual.<br>
> ><br>
> > Yours,<br>
> > Roland<br>
> > <br>
> > > Hello,<br>
> > ><br>
> > > Please consider joining the weekly Einstein Toolkit phone call at<br>
> > > 9:00 am US central time on Mondays. For details on how to connect<br>
> > > and what agenda items are to be discussed, use the link below.<br>
> > ><br>
> > > <a href="https://docs.einsteintoolkit.org/et-docs/Main_Page#Weekly_Users_Call" rel="noreferrer" target="_blank">https://docs.einsteintoolkit.org/et-docs/Main_Page#Weekly_Users_Call</a> <br>
> > <<br>
> > <a href="https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.einsteintoolkit.org%2Fet-docs%2FMain_Page&data=01%7C01%7Chelvi.witek%40kcl.ac.uk%7C8afba93ca1394f93112108d59c956bc3%7C8370cf1416f34c16b83c724071654356%7C0&sdata=NiaoD6IydyP1Y7iD5lgdJYyu47Zyv%2Byxy9ZJYCCfzLo%3D&reserved=0" rel="noreferrer" target="_blank">https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.einsteintoolkit.org%2Fet-docs%2FMain_Page&data=01%7C01%7Chelvi.witek%40kcl.ac.uk%7C8afba93ca1394f93112108d59c956bc3%7C8370cf1416f34c16b83c724071654356%7C0&sdata=NiaoD6IydyP1Y7iD5lgdJYyu47Zyv%2Byxy9ZJYCCfzLo%3D&reserved=0</a> <br>
> > ><br>
> > ><br>
> > > --Steve<br>
> > > <br>
> ><br>
> ><br>
> ><br>
> > --<br>
> > My email is as private as my paper mail. I therefore support encrypting<br>
> > and signing email messages. Get my PGP key from <a href="http://pgp.mit.edu" rel="noreferrer" target="_blank">http://pgp.mit.edu</a> .<br>
> > _______________________________________________<br>
> > Users mailing list<br>
> > <a href="mailto:Users@einsteintoolkit.org" target="_blank">Users@einsteintoolkit.org</a><br>
> > <a href="http://lists.einsteintoolkit.org/mailman/listinfo/users" rel="noreferrer" target="_blank">http://lists.einsteintoolkit.org/mailman/listinfo/users</a><br>
> > <br>
> <br>
> <br>
<br>
<br>
<br>
-- <br>
My email is as private as my paper mail. I therefore support encrypting<br>
and signing email messages. Get my PGP key from <a href="http://pgp.mit.edu" rel="noreferrer" target="_blank">http://pgp.mit.edu</a> .<br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr">
<p><span>Prof. Bruno Giacomazzo<br></span><span style="font-size:12.8000001907349px">Department of Physics<br></span><span style="font-size:12.8000001907349px">University of Trento<br></span><span style="font-size:12.8000001907349px">via Sommarive 14<br></span><span style="font-size:12.8000001907349px">38123 Trento<br></span><span style="font-size:12.8000001907349px">Italy</span></p>
<p><span>Tel. : +39 0461281631<br></span><span style="font-size:12.8000001907349px">email : </span><span style="font-size:12.8000001907349px"><a href="mailto:bruno.giacomazzo@unitn.it" style="font-size:12.8000001907349px" target="_blank">bruno.giacomazzo@unitn.it</a><br></span><span style="font-size:12.8000001907349px">web: </span><span style="font-size:12.8000001907349px"><a href="http://www.brunogiacomazzo.org/" style="font-size:12.8000001907349px" target="_blank">http://www.brunogiacomazzo.org</a></span></p>
<p><span>----------------------------------------------------------------------<br></span><span style="font-size:12.8000001907349px">There are only 10 types of people in the world:<br></span><span style="font-size:12.8000001907349px">Those who understand binary, and those who don't<br></span><span style="font-size:12.8000001907349px">----------------------------------------------------------------------</span></p></div></div></div></div>