<div dir="ltr">Roland,<div> thank you for your feedback. It is my understanding that AHFinderDirect was able to find the horizons since it produced the BH diagnostic files. Federico: can you double check it?</div><div><br></div><div> Adding SphericalSurface::sf_valid to the scalar output seems to be a very good suggestion. </div><div><br></div><div>Thank you very much,</div><div>Bruno</div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Il giorno ven 21 feb 2020 alle ore 19:29 Roland Haas <<a href="mailto:rhaas@illinois.edu">rhaas@illinois.edu</a>> ha scritto:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hello Federico, Bruno,<br>
<br>
> let me add the AHFinderDirect correctly finds an AH after merger (the one<br>
> that should be stored in surface 2).<br>
Looking at the source for Outflow (the line number given by the<br>
warning):<br>
<br>
--8<--<br>
957 if (sf_valid[sn]<=0) {<br>
958 CCTK_VWarn(1, __LINE__, __FILE__, CCTK_THORNSTRING,<br>
959 "didn't find valid detector surface for sn=%d, det=%d",(int)sn,(int)det);<br>
960 continue;<br>
961 }<br>
--8<--<br>
<br>
this warning is output exactly when the surface is not marked as not<br>
"valid" which AHFinderDirect does if it cannot find a horizon or did<br>
not look for it, in driver/BH_diagnostics.cc (the lack of a "return" in<br>
line 678 looks like a bug to me):<br>
<br>
--8<--<br>
674 if ((my_dont_find_after >= 0 and cctk_iteration > my_dont_find_after) or<br>
675 (my_dont_find_after_time > my_find_after_time and cctk_time > my_dont_find_after_time))<br>
676 {<br>
677 assert (! AH_data.search_flag);<br>
678 sf_active[surface_number] = 0;<br>
679 }<br>
680<br>
681 // only try to copy AH info if we've found AHs at this time level<br>
682 if (! AH_data.search_flag) {<br>
683 sf_valid[surface_number] = 0;<br>
684 return;<br>
685 }<br>
686<br>
687 // did we actually *find* this horizon?<br>
688 if (! AH_data.found_flag) {<br>
689 sf_valid[surface_number] = -1;<br>
690 return;<br>
691 }<br>
692<br>
693 sf_active [surface_number] = 1;<br>
--8<--<br>
<br>
> Moreover, Federico also run a sim in which AHFinderDirect was writing on<br>
> surfaces 0, 1, and 2 while PunctureTracker was writing on surfaces 3 and 4.<br>
> In this case Outflow was giving the same error on all three surfaces 0, 1,<br>
> and 2.<br>
So as far as I can tell AHFinderDirect did indeed not find it or not try to<br>
find it. <br>
<br>
> My naive impression is that we are missing something and AHFinderDirect is<br>
> not saving the surfaces properly and therefore Outflow is not able to read<br>
> them.<br>
Are you perhaps asking it to stop searching (the parfile does not seem<br>
to indicate this but still)? In that case valid=0 and Outflow will no<br>
longer use that surface. You could request (scalar) output for<br>
SphericalSurface::sf_valid to track the state of the variable.<br>
<br>
> I had a look at previous par files from my BNS simulations (where Outflow<br>
> worked) and the only difference I saw was in the number of points in theta<br>
> and phi for the surfaces.<br>
That would not make a difference to Outflow.<br>
<br>
Yours,<br>
Roland<br>
<br>
-- <br>
My email is as private as my paper mail. I therefore support encrypting<br>
and signing email messages. Get my PGP key from <a href="http://pgp.mit.edu" rel="noreferrer" target="_blank">http://pgp.mit.edu</a> .<br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><p><font color="#000000">Pr<font face="arial, sans-serif">of. Bruno Giacomazzo<br>Department of Physics<br>University of Milano-Bicocca<br></font></font><span style="color:rgb(0,0,0)"><font face="arial, sans-serif">Piazza della Scienza 3<br></font></span><span style="color:rgb(0,0,0)"><font face="arial, sans-serif">20126 Milano<br></font></span><span style="font-size:12.8px;color:rgb(0,0,0)">Italy</span></p><p><font color="#000000"><span style="font-size:12.8px">email: </span><span style="font-size:12.8px"><a href="mailto:bruno.giacomazzo@unimib.it" target="_blank">bruno.giacomazzo@unimib.it</a><br></span><span style="font-size:12.8px">phone: (+39) 02 6448 2321</span></font><br><font color="#000000"><span style="font-size:12.8px">web: </span></font><span style="color:rgb(0,0,0);font-size:12.8px"><a href="http://www.brunogiacomazzo.org/" style="font-size:12.8px" target="_blank">http://www.brunogiacomazzo.org</a></span></p><p><font color="#000000">----------------------------------------------------------------------<br><span style="font-size:12.8px">There are only 10 types of people in the world:<br></span><span style="font-size:12.8px">Those who understand binary, and those who don't<br></span><span style="font-size:12.8px">----------------------------------------------------------------------<br></span></font></p></div></div></div></div></div></div></div>