<div dir="ltr"><div class="gmail_default" style="font-family:courier new,monospace">Aha! Thanks Roland. I'm composing a ticket on the Kranc GitHub now.</div><div class="gmail_default" style="font-family:courier new,monospace"><br></div><div class="gmail_default" style="font-family:courier new,monospace">Bernard</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, 24 Feb 2021 at 15:25, Roland Haas <<a href="mailto:rhaas@illinois.edu" target="_blank">rhaas@illinois.edu</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hello Bernard, all,<br>
<br>
the failure is due to a change in ValueQ:<br>
<br>
<a href="https://reference.wolfram.com/language/ref/ValueQ.html" rel="noreferrer" target="_blank">https://reference.wolfram.com/language/ref/ValueQ.html</a><br>
<br>
which was updated in 12.2 (see "Details") and old behaviour would be<br>
restored by using ValueQ[_, Method->"Legacy"] but I have no clue of<br>
what that would mean.<br>
<br>
The failure goes away if one patches Kranc (though the issue may exist<br>
in other places as well, ValueQ seems pretty basic functionality to me):<br>
<br>
diff --git a/Tools/CodeGen/TensorTools.m b/Tools/CodeGen/TensorTools.m<br>
index 9e53a0a..1f17b35 100644<br>
--- a/Tools/CodeGen/TensorTools.m<br>
+++ b/Tools/CodeGen/TensorTools.m<br>
@@ -301,7 +301,7 @@ DefineTensor[T_] :=<br>
Module[<br>
{c},<br>
c = tensorCharacter[{is}];<br>
- If[!ValueQ[TensorCharacter[T]],<br>
+ If[!ValueQ[TensorCharacter[T], Method -> "Legacy"],<br>
TensorCharacter[T] = c,<br>
(* else *)<br>
If[!charactersMatch[c,TensorCharacter[T]],<br>
<br>
Best to report this on the Kranc issue tracker<br>
<a href="https://github.com/ianhinder/Kranc/issues" rel="noreferrer" target="_blank">https://github.com/ianhinder/Kranc/issues</a> I'd say.<br>
<br>
Note that "Method -> Legacy" probably *breaks* on older MMA versions<br>
(where the option may not yet exist) so is not a fix we can apply to<br>
Kranc in that case.<br>
<br>
Yours,<br>
Roland<br>
<br>
> Hello Bernard,<br>
> <br>
> yes, fails for me with MMA 12.2.0 as well:<br>
> <br>
> $ make McLachlan_BSSN.out<br>
> rm -rf ML_BSSN ML_BSSN_Helper<br>
> env ML_CODE=BSSN ./runmath.sh McLachlan_BSSN.m McLachlan_BSSN<br>
> Using Kranc installation at ../../../repos/Kranc/Bin/..<br>
> Mathematica 12.2.0 Kernel for Linux x86 (64-bit)<br>
> Copyright 1988-2020 Wolfram Research, Inc.<br>
> Profiling disabled<br>
> <br>
> MapThread::mptd: Object TensorTools`Private`TensorCharacter[dir] at position {2, 2} in MapThread[NumberQ[#1] || NumberQ[#2] || #1 === #2 & , {{u}, TensorTools`Private`TensorCharacter[dir]}] has only 0 of required 1 dimensions.<br>
> <br>
> MapThread::mptd: Object TensorTools`Private`TensorCharacter[epsdiss] at position {2, 2} in MapThread[NumberQ[#1] || NumberQ[#2] || #1 === #2 & , {{u}, TensorTools`Private`TensorCharacter[epsdiss]}] has only 0 of required 1 dimensions.<br>
> <br>
> Riffle::list: List expected at position 1 in Riffle[TensorTools`Private`TensorCharacter[gt], ,].<br>
> <br>
> StringJoin::string: String expected at position 1 in StringJoin[Riffle[TensorTools`Private`TensorCharacter[gt], ,]].<br>
> <br>
> StringJoin::string: String expected at position 2 in Tensor indices in gt[la,lb] do not match those used previously: gt[<>Riffle[TensorTools`Private`TensorCharacter[gt], ,]<>].<br>
> Error:<br>
> StringJoin["Tensor indices in gt[la,lb] do not match those used previously: gt[", Riffle[TensorTools`Private`TensorCharacter[gt], ","], "]"]<br>
> make: *** [Makefile:17: McLachlan_BSSN.out] Error 1<br>
> <br>
> Yours,<br>
> Roland<br>
> <br>
> > Hello Bernard,<br>
> > <br>
> > > Hi. I'm trying to regenerate the McLachlan ML_BSSN thorn by running the<br>
> > > Mathematica-based scripts on my Macbook. The process is failing, and I'd<br>
> > > like to know if it's an issue with my Mathematica installation or the<br>
> > > McLachlan code? <br>
> > Being the person who last regenerated McLachlan for the last ET<br>
> > release: I just gave this a try with 12.0.0 on Linux and there at least<br>
> > <br>
> > env ML_CODE=BSSN ./runmath.sh McLachlan_BSSN.m McLachlan_BSSN<br>
> > <br>
> > works.<br>
> > <br>
> > I will update to 12.2.1 and see what happens. If that fails then at<br>
> > least we know that we can check Wolframs docs do see what they<br>
> > functionality they removed to make this fail.<br>
> > <br>
> > Yours,<br>
> > Roland<br>
> > <br>
> <br>
> <br>
<br>
<br>
-- <br>
My email is as private as my paper mail. I therefore support encrypting<br>
and signing email messages. Get my PGP key from <a href="http://pgp.mit.edu" rel="noreferrer" target="_blank">http://pgp.mit.edu</a> .<br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr">------------------------------------------------------------------<br>Bernard Kelly -- CRESST Assistant Research Scientist, NASA/GSFC<br>Gravitational Astrophysics Laboratory --- Code 663<br> <br>Phone: +1 (301) 286-7243 *** Fax: +1 (301) 286-2226<br>Web: <a href="http://science.gsfc.nasa.gov/sed/bio/bernard.j.kelly" target="_blank">http://science.gsfc.nasa.gov/sed/bio/bernard.j.kelly</a><br>ORCID: <a href="http://orcid.org/0000-0002-3326-4454" target="_blank">orcid.org/0000-0002-3326-4454</a><br>------------------------------------------------------------------</div>