<div dir="ltr">Roland,<div> thank you very much for this summary.</div><div><br></div><div>Cheers,</div><div>Bruno</div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Il giorno gio 11 mar 2021 alle ore 17:26 Roland Haas <<a href="mailto:rhaas@illinois.edu">rhaas@illinois.edu</a>> ha scritto:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hello all,<br>
<br>
I dug up the old meeting minutes from when LORENE2 was first introduced<br>
(from 2016):<br>
<br>
<a href="http://lists.einsteintoolkit.org/pipermail/users/2016-October/005020.html" rel="noreferrer" target="_blank">http://lists.einsteintoolkit.org/pipermail/users/2016-October/005020.html</a><br>
<br>
basically we introduced LORENE2 to indicate the breaking change and<br>
left LORENE as the default version in the thornlist.<br>
<br>
At the very least we should be able to update LORENE2 to the current<br>
version (assuming no more breaking changes in between) and, if we want<br>
to deprecate LORENE1 and remove, possibly only in the release after the<br>
next one, switch defaults. The issue is that one cannot compile both<br>
thorns at the same time so switching from LORENE1 to LORENE2 will break<br>
existing parfiles (for example the gallery example).<br>
<br>
Making LORENE2 the default was a decision reached in the ET call on<br>
2018-03-12:<br>
<br>
<a href="http://lists.einsteintoolkit.org/pipermail/users/2018-March/006122.html" rel="noreferrer" target="_blank">http://lists.einsteintoolkit.org/pipermail/users/2018-March/006122.html</a><br>
<br>
where it says:<br>
<br>
--8<--<br>
updating LORENE:<br>
* make LORENE2 the default after verifying that everything compiles and<br>
that gallery example works with LORENE2<br>
* check that BBH ID from Meudon group can still be read<br>
* create ticket for this<br>
* get this done within a month<br>
--8<--<br>
<br>
and from future minutes, nothing seems to have happened though in <br>
<br>
<a href="http://lists.einsteintoolkit.org/pipermail/users/2018-October/006610.html" rel="noreferrer" target="_blank">http://lists.einsteintoolkit.org/pipermail/users/2018-October/006610.html</a><br>
<br>
it says<br>
<br>
--8<--<br>
* update ET to LORENE2<br>
** need to check that files can still be read<br>
** old ticket stated that there would be an abort for some files writen<br>
by old an read by new LORENE or vice versa<br>
--8<--<br>
<br>
and<br>
<br>
<a href="http://lists.einsteintoolkit.org/pipermail/users/2018-November/006634.html" rel="noreferrer" target="_blank">http://lists.einsteintoolkit.org/pipermail/users/2018-November/006634.html</a><br>
<br>
says<br>
<br>
--8<--<br>
LORENE2:<br>
* switch thornlist to have LORENE2 as the default<br>
--8<--<br>
<br>
and<br>
<br>
<a href="http://lists.einsteintoolkit.org/pipermail/users/2018-November/006661.html" rel="noreferrer" target="_blank">http://lists.einsteintoolkit.org/pipermail/users/2018-November/006661.html</a><br>
<br>
--8<--<br>
tasks for next Einstein Toolkit relelase trac listing:<br>
** LORENE2, should be enable in thornlist to compile, Zac wanted to provide a small data set to load it<br>
--8<--<br>
<br>
and the same note in <br>
<br>
<a href="http://lists.einsteintoolkit.org/pipermail/users/2018-November/006667.html" rel="noreferrer" target="_blank">http://lists.einsteintoolkit.org/pipermail/users/2018-November/006667.html</a><br>
<br>
However in 2018-02-03 an issue was raised by Zach<br>
<br>
<a href="http://lists.einsteintoolkit.org/pipermail/users/2018-December/006679.html" rel="noreferrer" target="_blank">http://lists.einsteintoolkit.org/pipermail/users/2018-December/006679.html</a><br>
<br>
--8<--<br>
WVUThorns:<br>
* Zach reported. He has a small-ish but not well understood LORENE2 <br>
initial data from his collaborator, has permissions to use it.<br>
* Working with Josh Faber (RIT) who is using LORENE2 for binary NS <br>
mergers, will have another small initial data set from him.<br>
* Discussion of a possible problem in LORENE2, a bug, that may make it <br>
incorrect. In the translation from French to English a subroutine was <br>
not translated. Also the LORENE1 initial data may not be useful in <br>
LORENE2.<br>
* Because of this Zach and Steve recommend proceeding with caution. <br>
Last week the conclusion had been to replace LORENE1 with LORENE2...now <br>
not recommended until this is understood/explored further.<br>
--8<--<br>
<br>
this <br>
<br>
<a href="http://lists.einsteintoolkit.org/pipermail/users/2018-December/006691.html" rel="noreferrer" target="_blank">http://lists.einsteintoolkit.org/pipermail/users/2018-December/006691.html</a><br>
<br>
provides<br>
<br>
--8<--<br>
LORENE:<br>
* Josh reported on bugs existing in the English named classes in LORENE<br>
in the newer part of the codebase that do not yet exist in the French<br>
named classed<br>
* Josh expects to send bug fixes back to LORENE but will take a while<br>
to track them down<br>
* not sure if the ET's LORENE1 already has these bugs present that<br>
exist in LORENE2<br>
--8<--<br>
<br>
after which there is no more updates.<br>
<br>
Yours,<br>
Roland<br>
<br>
> Roland,<br>
> thanks for the prompt reply. I will attend tomorrow's telecon, so that<br>
> maybe we can also discuss this.<br>
> <br>
> Cheers,<br>
> Bruno<br>
> <br>
> <br>
> Il giorno mer 10 mar 2021 alle ore 19:19 Roland Haas <<a href="mailto:rhaas@illinois.edu" target="_blank">rhaas@illinois.edu</a>><br>
> ha scritto:<br>
> <br>
> > Hello Bruno, Lorenzo,<br>
> > <br>
> > > the versions of LORENE available within the Einstein Tollkit (both <br>
> > LORENE <br>
> > > and LORENE2) are pretty old and they also include a few bugs that<br>
> > > have been fixed in the current version of the LORENE library<br>
> > > available on<br>
> > > <br>
> > <a href="https://urldefense.com/v3/__https://lorene.obspm.fr/__;!!DZ3fjg!prya273V4UErHsbCU9wuaiGbfk8SFwM2FGnhPz38kPYcjTJfxUKWzEigPXOZ3oBc$" rel="noreferrer" target="_blank">https://urldefense.com/v3/__https://lorene.obspm.fr/__;!!DZ3fjg!prya273V4UErHsbCU9wuaiGbfk8SFwM2FGnhPz38kPYcjTJfxUKWzEigPXOZ3oBc$</a> <br>
> > ><br>
> > > Would it be possible to add the current version of LORENE to the<br>
> > > Einstein Toolkit? <br>
> > Please take a look at:<br>
> ><br>
> ><br>
> > <a href="https://urldefense.com/v3/__https://bitbucket.org/einsteintoolkit/tickets/issues/2206/make-lorene2-the-default-lorene-in-the-et__;!!DZ3fjg!sQzhqrd-FfRVzvyiR7s2xXVb_rYLox9aCydPjVwamccZ6jUO3OA2ZWTMdN26LDSs$" rel="noreferrer" target="_blank">https://urldefense.com/v3/__https://bitbucket.org/einsteintoolkit/tickets/issues/2206/make-lorene2-the-default-lorene-in-the-et__;!!DZ3fjg!sQzhqrd-FfRVzvyiR7s2xXVb_rYLox9aCydPjVwamccZ6jUO3OA2ZWTMdN26LDSs$</a> <br>
> ><br>
> > and<br>
> ><br>
> > <a href="https://urldefense.com/v3/__https://bitbucket.org/einsteintoolkit/tickets/issues/1817*comment-50394946__;Iw!!DZ3fjg!sQzhqrd-FfRVzvyiR7s2xXVb_rYLox9aCydPjVwamccZ6jUO3OA2ZWTMdCEUyLuj$" rel="noreferrer" target="_blank">https://urldefense.com/v3/__https://bitbucket.org/einsteintoolkit/tickets/issues/1817*comment-50394946__;Iw!!DZ3fjg!sQzhqrd-FfRVzvyiR7s2xXVb_rYLox9aCydPjVwamccZ6jUO3OA2ZWTMdCEUyLuj$</a> <br>
> > <br>
> > > P.S.: btw, I was not able to find which version of LORENE the thorns<br>
> > > LORENE and LORENE2 refer to. I think LORENE2 is from 2015, but I'm<br>
> > > not 100% sure. <br>
> > The version in LORENE2 is listed in the ticket.<br>
> ><br>
> > LORENE unfortunately has introduced breaking changes in the past with<br>
> > no notice that this was done which makes it hard to follow along they<br>
> > development. It would be great if someone who uses LORENE would keep on<br>
> > top of this and provide pointers which versions are "safe" to include.<br>
> ><br>
> > Yours,<br>
> > Roland<br>
> ><br>
> > --<br>
> > My email is as private as my paper mail. I therefore support encrypting<br>
> > and signing email messages. Get my PGP key from <a href="https://urldefense.com/v3/__http://pgp.mit.edu__;!!DZ3fjg!sQzhqrd-FfRVzvyiR7s2xXVb_rYLox9aCydPjVwamccZ6jUO3OA2ZWTMdM3QrUdu$" rel="noreferrer" target="_blank">https://urldefense.com/v3/__http://pgp.mit.edu__;!!DZ3fjg!sQzhqrd-FfRVzvyiR7s2xXVb_rYLox9aCydPjVwamccZ6jUO3OA2ZWTMdM3QrUdu$</a> .<br>
> > <br>
> <br>
> <br>
<br>
<br>
-- <br>
My email is as private as my paper mail. I therefore support encrypting<br>
and signing email messages. Get my PGP key from <a href="http://pgp.mit.edu" rel="noreferrer" target="_blank">http://pgp.mit.edu</a> .<br>
<br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><p><font color="#000000">Pr<font face="arial, sans-serif">of. Bruno Giacomazzo<br>Department of Physics<br>University of Milano-Bicocca<br></font></font><span style="color:rgb(0,0,0)"><font face="arial, sans-serif">Piazza della Scienza 3<br></font></span><span style="color:rgb(0,0,0)"><font face="arial, sans-serif">20126 Milano<br></font></span><span style="font-size:12.8px;color:rgb(0,0,0)">Italy</span></p><p><font color="#000000"><span style="font-size:12.8px">email: </span><span style="font-size:12.8px"><a href="mailto:bruno.giacomazzo@unimib.it" target="_blank">bruno.giacomazzo@unimib.it</a><br></span><span style="font-size:12.8px">phone: (+39) 02 6448 2321</span></font><br><font color="#000000"><span style="font-size:12.8px">web: </span></font><span style="color:rgb(0,0,0);font-size:12.8px"><a href="http://www.brunogiacomazzo.org/" style="font-size:12.8px" target="_blank">http://www.brunogiacomazzo.org</a></span></p><p><font color="#000000">----------------------------------------------------------------------<br><span style="font-size:12.8px">There are only 10 types of people in the world:<br></span><span style="font-size:12.8px">Those who understand binary, and those who don't<br></span><span style="font-size:12.8px">----------------------------------------------------------------------<br></span></font></p></div></div></div></div></div></div></div>