<div dir="ltr"><div class="gmail_default" style="font-family:courier new,monospace">Hi Samuel.</div><div class="gmail_default" style="font-family:courier new,monospace"><br></div><div class="gmail_default" style="font-family:courier new,monospace">Your code fix did indeed fix the problem (without having to compile from scratch with DEBUG=no) -- thanks! (I also compiled on a different machine with DEBUG=no from scratch, and that ran OK too)</div><div class="gmail_default" style="font-family:courier new,monospace"><br></div><div class="gmail_default" style="font-family:courier new,monospace">I don't really understand what's going on here, though. I assume/hope that WeylScal4 will be updated to avoid the need for this patch ...</div><div class="gmail_default" style="font-family:courier new,monospace"><br></div><div class="gmail_default" style="font-family:courier new,monospace">Thanks again, Bernard</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Feb 29, 2024 at 3:45 PM Cupp, Samuel D. <<a href="mailto:scupp1@my.apsu.edu">scupp1@my.apsu.edu</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="msg-8649046324227071563">
<div dir="ltr">
<div><span style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">This should be a bug that only affects debug mode. Looking through the code, I think
I've tracked back the issue. The RDWR attribute for functions</span><span style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)"> (set in CCTKi_CreateRDWRData)</span><span style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)"> is
only defined if presync_mode is set to something other than "off" (the default). As such, this section of code should be bypassed for that parameter setting. As a quick fix, you could change line 324 of repos/flesh/src/main/RDWR.cc</span></div>
<div><span style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)"><br>
</span></div>
<div style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
from</div>
<div style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<br>
</div>
<div><span style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)"> if(cctkGH == nullptr))</span></div>
<div><span style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)"><br>
</span></div>
<div style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
to</div>
<div style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<br>
</div>
<div><span style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)"> if(cctkGH == nullptr || CCTK_Equals(presync_mode, "off"))</span></div>
<div><span style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)"><br>
</span></div>
<div><span style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">Let me know if that fixes the issue.</span></div>
<div id="m_-8649046324227071563Signature">
<div id="m_-8649046324227071563divtagdefaultwrapper" dir="ltr" style="font-size:12pt;color:rgb(0,0,0);font-family:Calibri,Helvetica,sans-serif">
<br>
</div>
<div style="direction:ltr;font-family:Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<span style="font-family:Calibri,Helvetica,sans-serif,serif,EmojiFont;font-size:16px"> Samuel Cupp
</span></div>
<div id="m_-8649046324227071563divtagdefaultwrapper" dir="ltr" style="font-size:12pt;font-family:Calibri,Helvetica,sans-serif">
<span style="font-family:Calibri,Helvetica,sans-serif,serif,EmojiFont"> Postdoctoral Researcher<br>
</span></div>
<div id="m_-8649046324227071563divtagdefaultwrapper" dir="ltr" style="font-size:12pt;font-family:Calibri,Helvetica,sans-serif">
<span style="font-family:Calibri,Helvetica,sans-serif,serif,EmojiFont"> Department of Physics</span></div>
<div style="direction:ltr;font-family:Calibri,Helvetica,sans-serif;font-size:12pt">
<span style="font-family:Calibri,Helvetica,sans-serif,serif,EmojiFont;color:rgb(0,0,0)"> University of Idaho</span></div>
<div id="m_-8649046324227071563divtagdefaultwrapper" dir="ltr" style="font-size:12pt;color:rgb(0,0,0);font-family:Calibri,Helvetica,sans-serif">
</div>
</div>
<div id="m_-8649046324227071563appendonsend"></div>
<hr style="display:inline-block;width:98%">
<div id="m_-8649046324227071563divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Bernard Kelly <<a href="mailto:physicsbeany@gmail.com" target="_blank">physicsbeany@gmail.com</a>><br>
<b>Sent:</b> Thursday, February 29, 2024 12:29 PM<br>
<b>To:</b> Cupp, Samuel D. <<a href="mailto:scupp1@my.apsu.edu" target="_blank">scupp1@my.apsu.edu</a>><br>
<b>Cc:</b> Einstein Toolkit Users <<a href="mailto:Users@einsteintoolkit.org" target="_blank">Users@einsteintoolkit.org</a>><br>
<b>Subject:</b> Re: [Users] WeylScal4 failing testsuites with ET_2023_11</font>
<div> </div>
</div>
<div>
<div dir="ltr">
<div style="font-family:"courier new",monospace">Hi Samuel. Thanks for the quick response.</div>
<div style="font-family:"courier new",monospace"><br>
</div>
<div style="font-family:"courier new",monospace">For both code releases (ET_2023_05 and ET_2023_11), I have DEBUG=yes in my config.</div>
<div style="font-family:"courier new",monospace"><br>
</div>
<div style="font-family:"courier new",monospace">Now that you've pointed it out, I *could* recompile from scratch with DEBUG=no ... but should I have to? And is this just covering up an actual bug (as the name implies)?</div>
<div style="font-family:"courier new",monospace"><br>
</div>
<div style="font-family:"courier new",monospace">Bernard</div>
</div>
<br>
<div>
<div dir="ltr">On Thu, Feb 29, 2024 at 3:23 PM Cupp, Samuel D. <<a href="mailto:scupp1@my.apsu.edu" target="_blank">scupp1@my.apsu.edu</a>> wrote:<br>
</div>
<blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
<div dir="ltr">
<div style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
Hi Bernard,</div>
<div style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
Is your parfile setting the parameter presync_mode? Alternatively, did you compile in debug mode? I ask this because that function has the following code</div>
<div><span style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)"><br>
</span></div>
<div><span style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)"> static bool presync_only = CCTK_Equals(presync_mode, "presync-only");</span></div>
<div><span style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">#ifndef CCTK_DEBUG</span></div>
<div><span style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)"> if(!presync_only)</span></div>
<div><span style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)"> return true;</span></div>
<div><span style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">#endif</span></div>
<div><span style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)"><br>
</span></div>
<div><span style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">Unless I'm reading this section incorrectly, the code shouldn't reach that assertion unless its in debug mode or the mode
is "presync-only".</span></div>
<div id="m_-8649046324227071563x_m_-8032531754002901550Signature">
<div dir="ltr" id="m_-8649046324227071563x_m_-8032531754002901550divtagdefaultwrapper" style="font-size:12pt;font-family:Calibri,Helvetica,sans-serif">
<br>
</div>
<div style="direction:ltr;font-family:Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<span style="font-family:Calibri,Helvetica,sans-serif,serif,EmojiFont;font-size:16px"> Samuel Cupp
</span></div>
<div dir="ltr" id="m_-8649046324227071563x_m_-8032531754002901550divtagdefaultwrapper" style="font-size:12pt;font-family:Calibri,Helvetica,sans-serif">
<span style="font-family:Calibri,Helvetica,sans-serif,serif,EmojiFont"> Postdoctoral Researcher<br>
</span></div>
<div dir="ltr" id="m_-8649046324227071563x_m_-8032531754002901550divtagdefaultwrapper" style="font-size:12pt;font-family:Calibri,Helvetica,sans-serif">
<span style="font-family:Calibri,Helvetica,sans-serif,serif,EmojiFont"> Department of Physics</span></div>
<div style="direction:ltr;font-family:Calibri,Helvetica,sans-serif;font-size:12pt">
<span style="font-family:Calibri,Helvetica,sans-serif,serif,EmojiFont;color:rgb(0,0,0)"> University of Idaho</span></div>
<div dir="ltr" id="m_-8649046324227071563x_m_-8032531754002901550divtagdefaultwrapper" style="font-size:12pt;font-family:Calibri,Helvetica,sans-serif">
</div>
</div>
<div id="m_-8649046324227071563x_m_-8032531754002901550appendonsend"></div>
<hr style="display:inline-block;width:98%">
<div id="m_-8649046324227071563x_m_-8032531754002901550divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Users <<a href="mailto:users-bounces@einsteintoolkit.org" target="_blank">users-bounces@einsteintoolkit.org</a>> on
behalf of Bernard Kelly <<a href="mailto:physicsbeany@gmail.com" target="_blank">physicsbeany@gmail.com</a>><br>
<b>Sent:</b> Thursday, February 29, 2024 11:58 AM<br>
<b>To:</b> Einstein Toolkit Users <<a href="mailto:Users@einsteintoolkit.org" target="_blank">Users@einsteintoolkit.org</a>><br>
<b>Subject:</b> [Users] WeylScal4 failing testsuites with ET_2023_11</font>
<div> </div>
</div>
<div>
<div dir="ltr">
<div style="font-family:"courier new",monospace">Hi. I just tried running a parameter file with WeylScal4 using the ET_2023_11 release, and it fails during the pre-initial stage, with screen output like the following:</div>
<div style="font-family:"courier new",monospace"><br>
</div>
<div style="font-family:"courier new",monospace">-------------</div>
<div style="font-family:"courier new",monospace">NFO (CarpetIOHDF5): I/O Method 'IOHDF5_1D' registered: 1D AMR output of grid variables to HDF5 files<br>
INFO (CarpetIOHDF5): I/O Method 'IOHDF5_2D' registered: 2D AMR output of grid variables to HDF5 files<br>
INFO (CarpetIOHDF5): Periodic 2D AMR output requested for:<br>
ML_ADMCONSTRAINTS::H<br>
INFO (CarpetIOHDF5): I/O Method 'IOHDF5_3D' registered: 3D AMR output of grid variables to HDF5 files<br>
INFO (CarpetIOScalar): Periodic scalar output requested for:<br>
ML_BSSN::H<br>
ML_BSSN::M1<br>
ML_BSSN::M2<br>
ML_BSSN::M3<br>
cactus_sim_ET_2023_11_WS4_ORIG: /nobackupp19/bjkelly1/codes/Cactus_ET_2023_11/configs/sim/build/Cactus/main/RDWR.cc:336: int cctki_RDWR::CCTK_HasAccess(const _cGH *, int): Assertion `current_function->RDWR' failed.<br>
Rank 3 with PID 73750 received signal 6<br>
Writing backtrace to Kerr_LES_StandardSpin_VACUUM_dx032_WS4_ORIG/backtrace.3.txt<br>
</div>
<div style="font-family:"courier new",monospace">-------------</div>
<div style="font-family:"courier new",monospace"><br>
</div>
<div style="font-family:"courier new",monospace">I tried to run the WeylScal4 testsuites too (Teukolsky etc), with the same "Assertion `current_function->RDWR' failed" message.</div>
<div style="font-family:"courier new",monospace"><br>
</div>
<div style="font-family:"courier new",monospace">Just to check, I went back an ET release (ET_2023_05), and did the same test, and the tests ran & passed.</div>
<div style="font-family:"courier new",monospace"><br>
</div>
<div style="font-family:"courier new",monospace">So did something happen between releases to change the behavior of WeylScal4? And would it affect other Kranc-generated thorns too?</div>
<div style="font-family:"courier new",monospace"><br>
</div>
<div style="font-family:"courier new",monospace">Thanks, Bernard</div>
<div><br>
</div>
<span>-- </span><br>
<div dir="ltr">------------------------------------------------------------------<br>
Bernard Kelly -- CRESST Assistant Research Scientist, NASA/GSFC<br>
Gravitational Astrophysics Laboratory --- Code 663<br>
<br>
Phone: +1 (301) 286-7243 *** Fax: +1 (301) 286-2226<br>
Web: <a href="http://science.gsfc.nasa.gov/sed/bio/bernard.j.kelly" target="_blank">
http://science.gsfc.nasa.gov/sed/bio/bernard.j.kelly</a><br>
ORCID: <a href="http://orcid.org/0000-0002-3326-4454" target="_blank">
orcid.org/0000-0002-3326-4454</a><br>
------------------------------------------------------------------</div>
</div>
</div>
</div>
</div>
</blockquote>
</div>
<br clear="all">
<div><br>
</div>
<span>-- </span><br>
<div dir="ltr">------------------------------------------------------------------<br>
Bernard Kelly -- CRESST Assistant Research Scientist, NASA/GSFC<br>
Gravitational Astrophysics Laboratory --- Code 663<br>
<br>
Phone: +1 (301) 286-7243 *** Fax: +1 (301) 286-2226<br>
Web: <a href="http://science.gsfc.nasa.gov/sed/bio/bernard.j.kelly" target="_blank">
http://science.gsfc.nasa.gov/sed/bio/bernard.j.kelly</a><br>
ORCID: <a href="http://orcid.org/0000-0002-3326-4454" target="_blank">
orcid.org/0000-0002-3326-4454</a><br>
------------------------------------------------------------------</div>
</div>
</div>
</div></blockquote></div><br clear="all"><div><br></div><span class="gmail_signature_prefix">-- </span><br><div dir="ltr" class="gmail_signature">------------------------------------------------------------------<br>Bernard Kelly -- CRESST Assistant Research Scientist, NASA/GSFC<br>Gravitational Astrophysics Laboratory --- Code 663<br> <br>Phone: +1 (301) 286-7243 *** Fax: +1 (301) 286-2226<br>Web: <a href="http://science.gsfc.nasa.gov/sed/bio/bernard.j.kelly" target="_blank">http://science.gsfc.nasa.gov/sed/bio/bernard.j.kelly</a><br>ORCID: <a href="http://orcid.org/0000-0002-3326-4454" target="_blank">orcid.org/0000-0002-3326-4454</a><br>------------------------------------------------------------------</div>