#2648: Empty ApplyBCs call in LeanBSSNMoL
| Reporter: | Samuel Cupp |
| Status: | new |
| Milestone: | |
| Version: | |
| Type: | bug |
| Priority: | major |
| Component: | EinsteinToolkit thorn |
Comment (by helvi witek):
Regarding this being a “major bug:
Note: “major” bugs are those that affect results and must be fixed before the next release. If the maintainers of lean_public and Baikal could look into this and adjust the severity setting accordingly that would be great.
Since the physics results have been thoroughly tested and benchmarked, I do not evaluate as a major bug. If Sam is correct, it would do nothing.
However, this needs to be checked for a non-trivial example (e.g. binary black holes), before we take it out.
@Samuel Cupp @Miguel Zilhão Could you please run a set of 2 tests, one with and one without the “ApplyBCs” being called right after adm2bssn? I suggest to used the standard, small BBH run with q=1, d=6M
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2648/empty-applybcs-call-in-leanbssnmol