Comment (by Roland Haas):

At this point, in IllinoisGRMHD, while I have not fully dug down into the code it seems that the changes do no more harm that usual development for new features. Ie I can see that there may be roundoff / truncation level differences due to updated equations, there is nothing that obviously will break things.

Comments:

• instead of hand-crafting parallelism in generate_IllinoisGRMHD_from_ipynb_files.sh it may be better to provide a makefile. Note that the current script likely does not what you expect it does. Namely “wait” waits for all child processes to finish no any. “Proper” parallelism could be achieved by using (GNU) xargs' -P option, though make seems preferable to me.
• generate_IllinoisGRMHD_from_ipynb_files.sh modifies the input notebooks (in the sed line). It really should not do so.
• Currently removing the output thorn directories Convert_to_HydroBase and ID_converter_ILGRMHD and running generate_IllinoisGRMHD_from_ipynb_files.sh does not regenerate all files, ie. there are hand-written files mixed in with the auto-generated ones (license, README, documentation.tex). It would be better if this was not done.
• A duplicate of the notebook is included in the thorn’s doc directory and that duplicate is not auto-generated. This will lead to inconsistencies and should be avoided.
• generate_illinoisgrmhd_from_ipynb_files.sh only generated Convert_to_HydroBase and ID_converter_ILGRMHD but not the actual IllinoisGRMHD thorn. Update after call: I now see where they are generated.
• Some places significantly (and to me surprisingly) simplify the code eg:

static CCTK_REAL pressure_rho0_w(CCTK_REAL rho0--

Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2300/update-add-piecewise-polytrope-eos-support