#595: unused function ParseEnvCommands in simfactory
Reporter:Frank Löffler
Status:resolved
Milestone:
Version:development version
Type:enhancement
Priority:minor
Component:SimFactory

Changes (by Roland Haas):

status:resolved (was new)

The function ParseEnvCommands is not used in simfactory, and as far as I can tell it is not doing what I think it should do. It should either be fully implemented (but that may already be provided elsewhere), or be removed.

Keyword:

Comment (by Roland Haas):

Removed in git hash fde3271 "simsubs: remove unused and incomplete ParseEnvCommands function" of simfactory2.

The current implementation had at least 2 bugs:

  1. it was substituting the empty string for everything
  2. the pattern to find @ENV(...)@ was way to greedy and assume whitespace after which would have prevented such uses as @END(SCRATCH)@/simulations which would be useful eg on TACC machines

Finally Cactus itself can use ENV in parameter files.

--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/595/unused-function-parseenvcommands-in