#2369: PreSync circumvents scoping of Cactus grid functions for C/C++ functions.
| Reporter: | Steven R. Brandt |
| Status: | open |
| Milestone: | ET_2020_11 |
| Version: | |
| Type: | bug |
| Priority: | major |
| Component: |
Comment (by Steven R. Brandt):
So the only thing that needs to be done here is convert warnings to errors. Correct?
diff --git a/lib/sbin/rdwr.pl b/lib/sbin/rdwr.pl index 24b3cf12..e1be427c 100644 --- a/lib/sbin/rdwr.pl +++ b/lib/sbin/rdwr.pl @@ -527,7 +527,7 @@ sub create_macros $hint = "Check variable or group '${th}::$full_var' and verify ". "correct implementation/thorn name and variable name.'"; } - &CST_error(1, "Error in read/write declaration of '${th}::$full_var' for '$nm' in schedule." + &CST_error(0, "Error in read/write declaration of '${th}::$full_var' for '$nm' in schedule." ,$hint, $errline, $ccl_file); next; } @@ -536,7 +536,7 @@ sub create_macros # the variable type... if($vtype eq "CCTK_") { my $hint = "Bad variable group name '$full_var' at $errline"; - &CST_error(1, "Error in read/write declaration $nm schedule. Check variable or group '$full_var'" . + &CST_error(0, "Error in read/write declaration $nm schedule. Check variable or group '$full_var'" . ' and verify correct implementation/thorn name and variable name.' ,$hint, $errline, $ccl_file); next; @@ -569,7 +569,7 @@ sub create_macros if(!defined($decls->{$full_var})) { my $line = $reads_writes->{$namekey}->{$th}->{$full_var}->{line}; my $hint = "Check access of variable. M--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2369/presync-circumvents-scoping-of-cactus-grid