Comment (by helvi witek):

[Zach’s response]

Hi Helvi and Roland.

Here is my response on the Baikal ETK thorns "Baikal" and "BaikalVacuum".

Thanks again Helvi for this amazing review. The Baikal ETK thorns are much better as a result! I believe I have completed all requested changes and made all appropriate fixes. Please see comments below.

Report on Baikal ETK (13 May 2020)
--------------------------------
- Two thorns "Baikal" (Einstein's equations coupled to Tmn) and "BaikalVacuum" (Einstein's equations in vacuum)
- very clean and readable implementation, both the the jupyter notebook and the auto-generated code.
- exceptionally well documented
- benchmarked against McLachlan (and Lean test is underway): reproduces standard qc0 run (BBH with 1 orbit before merger)

BaikalVacuum (15 May 2020):
---------------
- same comments as above, except for schedule.ccl (BSSN->ADM conversion seems correct)

Yep, see responses to Baikal.

- you might consider adding a documenting notebook that you used to generate the vacuum code (similar to the "doc" folder in Baikal)

Both thorns are generated using the same notebook, simultaneously. Regardless this is a good point (BaikalVacuum currently has no doc directory), so I added documentation.tex files along the lines Roland suggested (include a short description and links to the full documentation).

- [OK] in "par": what is difference between bench-qc0-...par and qc0-...par?

bench-* is for benchmarking purposes only; it only outputs to a bare minimum of files to avoid file I/O from causing noisy benchmarks. qc0-*.par is for science, outputting all the usual diagnostics files.

- [OK] example parameter files do not use symmetry? Why? not implemented or not used?

Symmetries aren't yet

--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2299/proposal-add-baikaletk-to-the-toolkit