The GRHydro WENO reconstruction code selected by GRHydro::recon_method = "weno" employs incorrect values for the weno_coeffs array that is constructed from the WENO $omega_r$ values.

The current values are in fact WENO interpolation instead of WENO reconstruction.

Pull request

https://bitbucket.org/einsteintoolkit/einsteinevolve/pull-requests/17/rhaas-wenocoeffsfix

corrects the coefficients, re-computing them from the original publication used to implement the code (“WHAM paper”, https://arxiv.org/abs/0704.2608) and updates the test data as well.

The attached stand-alone test (extracted code from GRHydro) demonstrates the issue and shows that only WENO-Z and WHAM’s WENO do show the WENO property of exactly reconstructing smooth data of low order polynomials (2nd order in the test, but should be up to 5th order). It also shows that WENO as implemented by GRHydro is actually WENO interpolation.

This effectively reduces WENO to a 2nd order accurate scheme similar to a basic tvd scheme I would guess.

attachment:

weno.cc

--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2647/incorrect-weno-coefficient-in-grhydro-weno