Comment (by Hayley Macpherson):

@Zach Etienne thanks for your review! I have addressed all of the issues and comments you have raised, and pushed the changes to the repo.
In addition to the changes to address your issues/comments, I have also re-named the source files and routines themselves to be more consistent with ET standards.
Here I’ll explain what I’ve done:

• Issue 1: removed these statements from param.ccl as they were unused anyway
• Issue 2: Roland said he would have a look into this, so I’ll leave this be for now
• Issue 3: added a test.ccl file
• Issue 4: removed doc/cactus.sty
• Issue 5: thanks for this! I’ve made a new routine FLRW_ParamCheck and scheduled it at ParamCheck as you suggested, and removed this code from the ID routines
• Issue 6/Comment 2: I’ve added a comment on the example powerspectrum file in the documentation, and added a new section explaining each of the files in the tools/ directory.
• Issue 7: I removed doc/tutorial/ and moved the README.tutorial file to tools/
• Comment 3: I removed configs/ from the public repo and will consider contributing these to simfactory at some point
• Issue 8: re-named the test par to FLRW_singlemode_test.par since the main differences are the resolution and simplified initial parameters
• Issue 9: thanks for pointing this out. I’ve added a call to CCTK_WARN after checking if the supplied file exists, with a useful error explaining next steps for the user
• Issue 10: removed the restart par file from par/
• Issue 11/Comment 4: thanks for this - I realised random.F90 was a lot more complicated than it needed to be. It already uses the intrinsic fortran PRNG, but had some added complexity in generating a seed if it wasn’t given. In FLRWSolver, there will always be a random seed. I removed random.F90 and replaced it with a new, much simpler routine in FLRW_InitTools which directly calls t

  --
  Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2549/inlcude-flrwsolver-in-et