#2368: Instabilities with Summation by Parts thorn 4th order operator
| Reporter: | Miguel Zilhão |
| Status: | open |
| Milestone: | |
| Version: | |
| Type: | bug |
| Priority: | major |
| Component: | EinsteinToolkit thorn |
Comment (by User e6f22):
Looking at the pull request and based on discussion in today’s ET call, I have the following review comments:
if and else branches of the 2nd derivatives are indentical, I would remove the if statement and replace it by a comment. Usually I would suggest replacing it by a check that the passed option is either “minimal bandwidth” or “optimal” choice for the operators, however the current code already does “minimal bandwith” or “other” so there seems little point of adding such a check now.Fine to apply otherwise.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2368/instabilities-with-summation-by-parts