#2497: IllinoisGRMHD is incompatible with setting TmunuBase::stress_energy_at_RHS = "no"
Reporter:Gabriele Bozzola
Status:open
Milestone:
Version:development version
Type:bug
Priority:major
Component:EinsteinToolkit thorn

Comment (by Leonardo Werneck):

After reviewing the issue more carefully, I think it is more prudent to fix it for the November release, as there won’t be enough time to fully test the code in time for this release. One possible solution is to modify IllinoisGRMHD’s schedule.ccl to add the con2prim function to the HydroBase_Con2Prim bin when TmunuBase::stress_energy_at_RHS="no", e.g.,

if(stress_energy_at_RHS)
{
  schedule IllinoisGRMHD_conserv_to_prims in AddToTmunu after compute_B_and_Bstagger_from_A
  {
    LANG: C
  } "Compute primitive variables from conservatives. This is non-trivial, requiring a Newton-Raphson root-finder."

  schedule IllinoisGRMHD_outer_boundaries_on_P_rho_b_vx_vy_vz in AddToTmunu after IllinoisGRMHD_conserv_to_prims
  {
    # We must sync {P,rho_b,vx,vy,vz} here.
    SYNC: grmhd_primitives_allbutBi
    LANG: C
  } "Apply outflow-only, flat BCs on {P,rho_b,vx,vy,vz}. Outflow only == velo

--

Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2497/illinoisgrmhd-is-incompatible-with-setting