#2907: Arith uses very generic names for its (global) include files
Reporter:Roland Haas
Status:new
Milestone:
Version:
Type:bug
Priority:minor
Component:CarpetX

Thorn Arith in CarpetX provides a number of helper functions for arithmetic operations. However it uses a large number of include files in its interface.ccl INCLUDES HEADER section. Since these file names are globally visible (not even restriction to other thorns REQUIREing Arith or having a USES HEADER in their interface.ccl, this pollutes (a) global name space (namely the configs/sim/bindings/include/ which all thorns use to search for include files using a -I compiler option). Right now the files are:

‌

INCLUDES HEADER: arr.hxx IN arr.hxx
INCLUDES HEADER: cons.hxx IN cons.hxx
INCLUDES HEADER: cplx.hxx IN cplx.hxx
INCLUDES HEADER: defs.hxx IN defs.hxx
INCLUDES HEADER: div.hxx IN div.hxx
INCLUDES HEADER: dual.hxx IN dual.hxx
INCLUDES HEADER: mat.hxx IN mat.hxx
INCLUDES HEADER: rational.hxx IN rational.hxx
INCLUDES HEADER: rten.hxx IN rten.hxx
INCLUDES HEADER: simd.hxx IN simd.hxx
INCLUDES HEADER: smallvector.hxx IN smallvector.hxx
INCLUDES HEADER: spvect.hxx IN spvect.hxx
INCLUDES HEADER: sum.hxx IN sum.hxx
INCLUDES HEADER: ten3.hxx IN ten3.hxx
INCLUDES HEADER: tuple.hxx IN tuple.hxx
INCLUDES HEADER: vec.hxx IN vec.hxx
INCLUDES HEADER: vect.hxx IN vect.hxx

of which vec.hxx and vect.hxx seem to be the most problematic.

It may be a good idea to consolidate these into fewer files and / or prefixing with arith_ or so to create a namespace.

--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2907/arith-uses-very-generic-names-for-its