#2908: Cactus: Fixed arg list too long error.
| Reporter: | Max Morris |
| Status: | submitted |
| Milestone: | |
| Version: | |
| Type: | bug |
| Priority: | major |
| Component: |
https://bitbucket.org/cactuscode/cactus/pull-requests/175
There is a check in lib/make/make.thornlib to ensure that sh is not passed an argument string which is too long. However, this check is not robust enough because it counts words instead of characters/bytes and compares against arbitrary magic numbers rather than checking the max argument string length of the system. I am working on a thorn which fails to build as a direct result of the faulty check.
This PR replaces the existing check with a more robust one based on $ getconf ARG_MAX, with reasonable fallback behavior if the system shell somehow doesn’t support this command.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2908/cactus-fixed-arg-list-too-long-error