#1974: Add WVUThorns_Diagnostics to the ET
| Reporter: | Zach Etienne |
| Status: | open |
| Milestone: | ET_2018_08 |
| Version: | development version |
| Type: | enhancement |
| Priority: | minor |
| Component: | Other |
Comment (by Steven R. Brandt):
This arrangement has about 2k lines of code. Now that tests are available, I'm in favor of adding it.
One problem I have with the code is that it makes use of the c-preprocessor when C++ offers better ways of doing things. I've created a pull request with a suggested refactoring: https://bitbucket.org/zach_etienne/wvuthorns_diagnostics/pull-requests/1/avoid-using-the-c-preprocessor-to-define/diff
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/1974/add-wvuthorns_diagnostics-to-the-et