#2497: IllinoisGRMHD is incompatible with setting TmunuBase::stress_energy_at_RHS = "no"
Reporter:Gabriele Bozzola
Status:open
Milestone:
Version:development version
Type:bug
Priority:major
Component:EinsteinToolkit thorn

Comment (by Gabriele Bozzola):

Upon further inspection, the PR does not solve the problem. The group SetTmunu is not added to the scheduler when TmunuBase::stress_energy_at_RHS = "no"

I don’t know how to fix this in a clean and easy way. The scheduler looks like this

            GROUP HydroBase_Con2Prim: Convert from conservative to primitive variables
          GROUP SetTmunu: Group for calculating the stress-energy tensor
            TmunuBase::TmunuBase_ZeroTmunu: Initialise the stress-energy tensor to zero
            GROUP AddToTmunu: Add to the stress-energy tensor here
               IllinoisGRMHD::IllinoisGRMHD_conserv_to_prims: Compute primitive variables from conservatives. This is non-trivial, requiring a Newton-Raphson root-finder.
               IllinoisGRMHD::IllinoisGRMHD_outer_boundaries_on_P_rho_b_vx_vy_vz: Apply outflow-only, flat BCs on {P,rho_b,vx,vy,vz}. Outflow only == velocities pointed inward from outer boundary are set to zero.

IllinoisGRMHD computes Tmunu when it is doing primitive-recovery (in IllinoisGRMHD_convser_to_prims), so, it has to be scheduled after TmunuBase_ZeroTmunu. However, the group SetTmunu does not exist at all when `TmunuBase::stress_energy_at_RHS = "no"

--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2497/illinoisgrmhd-is-incompatible-with-setting