#2426: g++-10 possibly miscompiles parts of Carpet
| Reporter: | Roland Haas |
| Status: | new |
| Milestone: | |
| Version: | |
| Type: | bug |
| Priority: | major |
| Component: | Other |
Comment (by Erik Schnetter):
I was afraid so. The bboxset2 implementation is among the most complex pieces of CarpetLib. It also was written at a time when C++11 support was immature. The first step might be to clean up the code by removing support for non-C++11 compilers.
Apart from this, the code is peppered by assert statements, and it used shared pointers (instead of more efficient unique pointers) to be more sure that it is correct. I wonder why the assert statements don’t trigger.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2426/g-10-possibly-miscompiles-parts-of-carpet