Comment (by Zach Etienne):

Here is the report from Codex. It did not have access to Steve's review:

• Issue 1
• Severity critical
• Description of the error The code advertises a 4-variable momentum-constraint solve via solve_momentum_constraint=yes, but the equation kernels still only populate values[0]. The extra three variables therefore have no equations, and the resulting nonlinear system is mathematically ill-posed.
• Filename + line number(s) TwoPuncturesX/src/TwoPunctures.cc:40-41, 302-306 TwoPuncturesX/src/Equations.cc:158-181
• Original code snippet if (solve_momentum_constraint) nvar = 4;

values[0] = U.d11[0] + U.d22[0] + U.d33[0] + 0.125 * BY_KKofxyz(x, y, z) / psi7 + 2.0 * Pi / psi2 / psi * rho_adm;

values[0] = dU.d11[0] + dU.d22[0] + dU.d33[0] - 0.875 * BY_KKofxyz(x, y, z) / psi8 * dU.d0[0];

SpecCoef(n1, n2, n3, 0, v.d0, cf_v.d0); - Fixed code snippet. if (solve_momentum_constraint) { CCTK_ERROR("solve_momentum_constraint=yes is not implemented in TwoPuncturesX"); }

/ Longer-term fix: implement and fill values[0..3] consistently, and generate/store spectral coefficients for all solved variables. / - Confidence 99%

• Issue 2
• Severity critical
• Description of the error Turning on sources while leaving the default rescale_sources=yes triggers an unconditional assert(0), so the source-enabled branch cannot run successfully.
• Filename + line number(s) TwoPuncturesX/src/TwoPunctures.cc:626-630 TwoPuncturesX/param.ccl:162-164
• Original code snippet if (use_sources && rescale_sources) { assert(0); // TODO: Implement via critical region #pragma omp single Rescale_Sources(cctkGH, np, vcoordx, vcoordy, vcoordz, NULL, gxx, gyy, gzz, gxy, gxz, gyz); }
• Fixed code

  --
  Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2931/claude-ai-edits-to-twopuncturesx