Comment (by Roland Haas):

Unless objected I will close this ticket as “resolved” after 2019-7-14.

The test remains in cctk_Config.h which is maybe a bit unfortunate since that is not a file one would normally have checked. A test in configure.in (ideally not requiring actually running code, so that it also works with cross compiling) would be nicer. Something like:

#if (defined __INTEL_COMPILER                &&                 \
     __INTEL_COMPILER_BUILD_DATE >= 20120731 &&                 \
     __INTEL_COMPILER_BUILD_DATE <  20130728 &&                 \
     !defined CCTK_INTEL_COMPILER_DONT_DISABLE_RESTRICT)
#error "icpc with failing __restrict__ handling detected"
#endif

would do the trick.

There are no longer any production machines with intel compilers which fall into this range. The oldest compiler available is on shelob with /usr/local/compilers/Intel/composer_xe_2013.5.192/bin/intel64/icpc which has a build date of 20130607 and thus would fall into the range of “buggy” compilers (>= 20120731 and <20130728) but passes the standalone test for me (no matter what optimization level I choose).

--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/1276/intel-20131117-mis-compiles-newrad