Comment (by Roland Haas):

I peeked at the code and it is using drand48() in an omp parallel section. However looking at "man drand48" it says that drand48 is not thread safe "MT-Unsafe race:drand48" so this seems wrong to use in a multi-threaded section.

drand48() is POSIX 2001 which Cactus technically does not require (it also requires a C99 compiler which we do not specifically point out and POSIX 2001 would seem to be 18 years old by now so should exist everywhere).

The README file should be closer to Cactus default so that it can be parsed for eg author, maintainer and license information.

Should not user printf() but instead CCTK_VINFO() so that output can be controlled by Cactus.

ID thorns are expected to only set ID for metric/gauge/hydro variables if the respective ADMBase / HydroBase variables are set to their registered parameter value (I do not know on top of my head the fraction of ID thorns that actually do so, TOVSolver, which to some degree is the prototypical ID thorn, does do so).

--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2286/add-the-fishbone-moncrief-initial-data