#2823: Include TOVola: An enhanced TOV solver with Tabulated EOS support
| Reporter: | David Boyer |
| Status: | open |
| Milestone: | ET_2024_11 |
| Version: | |
| Type: | enhancement |
| Priority: | major |
| Component: | EinsteinToolkit thorn |
Comment (by Roland Haas):
Comments looking at TOVola:
STRING TOVola_ODE_method in param.ccl should be KEYWORD TOVola_ODE_method0.0:* :: "Must be Positive" is incorrect, unless non-negative is enough. Should use (0.0:* :: "Must be positive" as the range (assuming the docs http://einsteintoolkit.org/usersguide/UsersGuide.html#x1-187000D2.3.2 still reflect the code and open intervals for double valued parameters have not been silently removed)TOVola_absolute_max_step and TOVola_absolute_min_step and possibly othersSTEERABLE=always probably makes no sense for a parameter used by an ID thorn, could be removed*.par files in output, violating https://docs.einsteintoolkit.org/et-docs/Adding_a_test_case#include <cctk.h> should be before any other includes (incl. system ones, since it brings in any DEFINES produced by ExternalLibraries). Should used #include "cctk.h" since cctk.his not a a system provided include file (https://www.gnu.org/software/c-intro-and-ref/manual/html_node/include-Syntax.html and --