#2823: Include TOVola: An enhanced TOV solver with Tabulated EOS support
Reporter:David Boyer
Status:open
Milestone:ET_2024_11
Version:
Type:enhancement
Priority:major
Component:EinsteinToolkit thorn

Comment (by Roland Haas):

Comments looking at TOVola:​
​

  1. the documentation does not adhere to the rules in http://einsteintoolkit.org/usersguide/UsersGuide.html#x1-115000C1.8.4 namely it does not correctly “namespace” the bibtex keys (important when building the ThornGuide which would see conflicting keys)
  2. STRING TOVola_ODE_method in param.ccl should be KEYWORD TOVola_ODE_method
  3. 0.0:* :: "Must be Positive" is incorrect, unless non-negative is enough. Should use (0.0:* :: "Must be positive" as the range (assuming the docs http://einsteintoolkit.org/usersguide/UsersGuide.html#x1-187000D2.3.2 still reflect the code and open intervals for double valued parameters have not been silently removed)
  4. same as 3 for TOVola_absolute_max_step and TOVola_absolute_min_step and possibly others
  5. STEERABLE=always probably makes no sense for a parameter used by an ID thorn, could be removed
  6. test parameter files produce *.par files in output, violating https://docs.einsteintoolkit.org/et-docs/Adding_a_test_case
  7. #include <cctk.h> should be before any other includes (incl. system ones, since it brings in any DEFINES produced by ExternalLibraries). Should used #include "cctk.h" since cctk.his not a a system provided include file (https://www.gnu.org/software/c-intro-and-ref/manual/html_node/include-Syntax.html and --
    Ticket URL:
    https://bitbucket.org/einsteintoolkit/tickets/issues/2823/include-tovola-an-enhanced-tov-solver-with