Changes (by Roland Haas):

status:

resolved (was open)

This works around deficiencies of the gethostname call, namely that it does not return an error of the supplied buffer is too small and that it may not include a NUL byte at the end of the buffer if the buffer was too small and the returned name was truncated.

This should not happen (often) in practise since glibc already has a similar workaround in place, but may happen eg on a Mac if they indeed use a non glibc C library.

Pull request is here: https://bitbucket.org/cactuscode/cactus/pull-requests/55/cactus-handle-error-in-gethostname/diff

Keyword: None

Comment (by Roland Haas):

Applied as git hash 0c12d0c7 "Cactus: handle error in gethostname" of cactus

--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2214/cactus-handle-error-in-gethostname