#2549: inlcude FLRWSolver in ET
| Reporter: | Roland Haas |
| Status: | new |
| Milestone: | ET_2022_05 |
| Version: | development version |
| Type: | enhancement |
| Priority: | major |
| Component: |
Comment (by Zach Etienne):
I’ll add comments as I have time.
First off, initial data thorns should depend on *Base thorns, and not any particular evolution thorn. I’m referring to
shares:GRHydro USES real rho_abs_min USES real rho_rel_min USES REAL initial_rho_abs_min USES REAL initial_rho_rel_min USES REAL initial_atmosphere_factor USES real GRHydro_rho_central
within param.ccl . It should be the initial data thorn’s responsibility to set up the atmosphere and set parameters accordingly. For me, the solver wouldn’t even get to the compile stage because I generally comment out GRHydro from my ThornList (naturally I use IllinoisGRMHD).
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2549/inlcude-flrwsolver-in-et