Zach
Apologies for missing half of the discussion this morning -- I had an unexpected visitor in my office.
- Is it necessary to have an explicit conversion thorn? Couldn't these routines be simply part of IllinoisGRMHD? For example, McLachlan uses its own variable, and contains its own routines to convert from/to ADMBase.
- If the routines really need to exist in two thorns, then I suggest having the actual routines in only one place, and calling the routines from the other place. (I probably completely missed the original motivation.) If necessary, you would need to introduce a third thorn containing these routines that these two thorns can call.
- Symbolic links will in general not work since they will lead to two different routines with the same name, something that confuses the Unix linker and may lead to random problems (segfaults, undefined symbols at link time, etc.) If identical code exists in different thorns, then the routines must have different names.
- Would scheduling "IN initial AFTER HydroBase_Initial" work?
- Similarly, there should be a group HydroBase_SetHydroBaseVars where the respective routine should be scheduled. I think half of the functionality that is present in ADMBase is still missing from HydroBase since, so far, there was only one thorn (... or two very similar thorns ...) that used HydroBase. Feel free to suggest the respective extensions to HydroBase, modelled after ADMBase if possible.
-erik